Strip special characters in extension omnibox suggestions.

chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h"
 
 #include <cmath>
 
 #include "base/stl_util.h"
 #include "base/sys_string_conversions.h"
@@ skipping 85 matching lines @@
 }
 static NSColor* URLTextColor() {
   return [NSColor colorWithCalibratedRed:0.0 green:0.55 blue:0.0 alpha:1.0];
 }
 }  // namespace
 
 // Helper for MatchText() to allow sharing code between the contents
 // and description cases.  Returns NSMutableAttributedString as a
 // convenience for MatchText().
 NSMutableAttributedString* OmniboxPopupViewMac::DecorateMatchedString(
-    const string16 &matchString,
+    const string16& matchStringIn,
     const AutocompleteMatch::ACMatchClassifications &classifications,
     NSColor* textColor, NSColor* dimTextColor, gfx::Font& font) {
   // Cache for on-demand computation of the bold version of |font|.
   NSFont* boldFont = nil;
 
+  string16 matchString;
+  const char16 kNewlineChar[] = { '\n', '\0' };
+  RemoveChars(matchStringIn, kNewlineChar, &matchString);

[Scott Hess - ex-Googler, 2011/10/20 19:54:03]

Should this remove the newline, or convert it to a space?  What about tabs? 
Linefeeds?  Random other control characters?

As a more general question, it seems like this should be solvable at the point
where the offending match contents are generated, rather than where they are
used.  Unfortunately, AutocompleteMatch is a struct where callers set contents
directly.  Since this problem is one where someone else controls what we
display, ExtensionAppProvider::Start() might be the chokepoint you want.  Are
newlines legitimate contents of matches in general?

+
   // Start out with a string using the default style info.
   NSString* s = base::SysUTF16ToNSString(matchString);
   NSDictionary* attributes = [NSDictionary dictionaryWithObjectsAndKeys:
                                   font.GetNativeFont(), NSFontAttributeName,
                                   textColor, NSForegroundColorAttributeName,
                                   nil];
   NSMutableAttributedString* as =
       [[[NSMutableAttributedString alloc] initWithString:s
                                               attributes:attributes]
         autorelease];
@@ skipping 702 matching lines @@
                         bottomLeftCornerRadius:kPopupRoundingRadius
                        bottomRightCornerRadius:kPopupRoundingRadius];
 
   // Draw the matrix clipped to our border.
   gfx::ScopedNSGraphicsContextSaveGState scopedGState;
   [path addClip];
   [super drawRect:rect];
 }
 
 @end