Strip special characters in extension omnibox suggestions.

chrome/renderer/resources/extensions/extension_process_bindings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetExtensionAPIDefinition();
@@ skipping 427 matching lines @@
         // if there is one.
         var id = arguments[0].menuItemId;
         var onclick = chromeHidden.contextMenus.handlers[id];
         if (onclick) {
           onclick.apply(null, arguments);
         }
       });
     };
   }
 
+  // Remove invalid characters from |text| so that it is suitable to use
+  // for |AutocompleteMatch::contents|.
+  function sanitizeString(text) {
+    // NOTE: This logic mirrors |AutocompleteMatch::SanitizeString()|.
+    // 0x2028 = line separator; 0x2029 = paragraph separator.
+    var kRemoveChars = /(\r|\n|\t|\u2028|\u2029)/gm;
+    return text.trimLeft().replace(kRemoveChars, '');
+  }
+
   // Parses the xml syntax supported by omnibox suggestion results. Returns an
   // object with two properties: 'description', which is just the text content,
   // and 'descriptionStyles', which is an array of style objects in a format
   // understood by the C++ backend.
   function parseOmniboxDescription(input) {
     var domParser = new DOMParser();
 
     // The XML parser requires a single top-level element, but we want to
     // support things like 'hello, <match>world</match>!'. So we wrap the
     // provided text in generated root level element.
@@ skipping 11 matching lines @@
     var result = {
       description: '',
       descriptionStyles: []
     };
 
     // Recursively walk the tree.
     (function(node) {
       for (var i = 0, child; child = node.childNodes[i]; i++) {
         // Append text nodes to our description.
         if (child.nodeType == Node.TEXT_NODE) {
-          result.description += child.nodeValue;
+          result.description += sanitizeString(child.nodeValue);

[Peter Kasting, 2011/10/27 18:37:10]

I don't actually know JS, so I'm going to assume this is right -- it looks as if
the input here is a tree of nodes that never actually specify lengths/character
ranges, so just sanitizing the text should be fine.

           continue;
         }
 
         // Process and descend into a subset of recognized tags.
         if (child.nodeType == Node.ELEMENT_NODE &&
             (child.nodeName == 'dim' || child.nodeName == 'match' ||
              child.nodeName == 'url')) {
           var style = {
             'type': child.nodeName,
             'offset': result.description.length
@@ skipping 543 matching lines @@
 
   if (!chrome.tts)
     chrome.tts = {};
 
   if (!chrome.ttsEngine)
     chrome.ttsEngine = {};
 
   if (!chrome.experimental.downloads)
     chrome.experimental.downloads = {};
 })();