Strip special characters in extension omnibox suggestions.

chrome/browser/autocomplete/autocomplete_match.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
+#include "base/string_util.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "grit/theme_resources.h"
 
 // AutocompleteMatch ----------------------------------------------------------
 
 AutocompleteMatch::AutocompleteMatch()
     : provider(NULL),
       relevance(0),
       deletable(false),
       inline_autocomplete_offset(string16::npos),
@@ skipping 133 matching lines @@
   classification->push_back(ACMatchClassification(match_location,
       (style | ACMatchClassification::MATCH) & ~ACMatchClassification::DIM));
 
   // Mark post-match portion of string (if any).
   const size_t after_match(match_location + match_length);
   if (after_match < overall_length) {
     classification->push_back(ACMatchClassification(after_match, style));
   }
 }
 
+// static
+string16 AutocompleteMatch::SanitizeString(const string16& text) {
+  // NOTE: This logic is mirrored by |sanitizeString()| in
+  // extension_process_bindings.js.
+  const char16 kRemoveChars[] = { '\n', '\r', '\t', 0x2028, 0x2029, 0 };

[Scott Hess - ex-Googler, 2011/10/26 21:08:00]

Document the crazy code points so I don't have to search to figure out why
they're in there.

[Alexei Svitkine (slow), 2011/10/27 13:30:53]

Done.

+  string16 result;
+  TrimWhitespace(text, TRIM_LEADING, &result);
+  RemoveChars(result, kRemoveChars, &result);

[Scott Hess - ex-Googler, 2011/10/26 21:08:00]

The potential for aliasing kinda frightens me, but AFAICT the implementation
will work fine using result as both in and out.

[Alexei Svitkine (slow), 2011/10/27 13:30:53]

Yeah, this is actually documented as safe to do for RemoveChars() in
string_util.h.

[Scott Hess - ex-Googler, 2011/10/27 18:28:37]

Oh, cool, I embarrassingly went direct to the implementation and didn't see the
documented contract.

+  return result;
+}
+
 #ifndef NDEBUG
 void AutocompleteMatch::Validate() const {
   ValidateClassifications(contents, contents_class);
   ValidateClassifications(description, description_class);
 }
 
 void AutocompleteMatch::ValidateClassifications(
     const string16& text,
     const ACMatchClassifications& classifications) const {
   if (text.empty()) {
@@ skipping 10 matching lines @@
   // The classifications should always be sorted.
   size_t last_offset = classifications[0].offset;
   for (ACMatchClassifications::const_iterator i(classifications.begin() + 1);
        i != classifications.end(); ++i) {
     DCHECK(i->offset > last_offset) << "Classification unsorted";
     DCHECK(i->offset < text.length()) << "Classification out of bounds";
     last_offset = i->offset;
   }
 }
 #endif