Strip special characters in extension omnibox suggestions.

chrome/browser/autocomplete/keyword_provider_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "chrome/browser/autocomplete/keyword_provider.h"
+#include "chrome/browser/extensions/extension_omnibox_api.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_service.h"
+#include "chrome/common/url_constants.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "googleurl/src/gurl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class KeywordProviderTest : public testing::Test {
  protected:
   template<class ResultType>
   struct test_data {
     const string16 input;
     const size_t num_results;
@@ skipping 188 matching lines @@
   template_url->set_short_name(ASCIIToUTF16("Test"));
   model_->Add(template_url);
   ASSERT_TRUE(template_url == model_->GetTemplateURLForKeyword(keyword));
 }
 
 TEST_F(KeywordProviderTest, RemoveKeyword) {
   string16 url(ASCIIToUTF16("http://aaaa/?aaaa=1&b={searchTerms}&c"));
   model_->Remove(model_->GetTemplateURLForKeyword(ASCIIToUTF16("aaaa")));
   ASSERT_TRUE(model_->GetTemplateURLForKeyword(ASCIIToUTF16("aaaa")) == NULL);
 }
+
+TEST_F(KeywordProviderTest, SuggestionMatchSanitize) {
+  struct TestData {
+    const char* description;
+    const char* match_contents;
+  } cases[] = {
+    { "Test", "Test" },
+    { "Test \n Test", "Test  Test" },
+    { "Test\r\t\nTest", "TestTest" },
+  };
+
+  // Register the "Test" keyword to avoid hitting a DCHECK() in
+  // |KeywordProvider::CreateAutocompleteMatch()|.
+  TemplateURL* template_url = new TemplateURL();
+  string16 keyword(ASCIIToUTF16("test"));
+  std::string url("http://www.example.com/?q={searchTerms}");
+  template_url->SetURL(url, 0, 0);
+  template_url->set_keyword(keyword);
+  template_url->set_short_name(ASCIIToUTF16("Test"));
+  model_->Add(template_url);
+
+  AutocompleteInput input(keyword, string16(),
+                          true, true, true, AutocompleteInput::BEST_MATCH);
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); ++i) {
+    ExtensionOmniboxSuggestion suggestion;
+    suggestion.description = ASCIIToUTF16(cases[i].description);
+    AutocompleteMatch match =
+        kw_provider_->CreateAutocompleteMatchFromSuggestion(model_.get(),
+                                                            keyword,
+                                                            input,
+                                                            suggestion,
+                                                            1);
+    EXPECT_EQ(ASCIIToUTF16(cases[i].match_contents), match.contents);
+  }
+}