Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 8363054: Fixing FileManagerDialogBrowserTest (Closed)

Created:
9 years, 1 month ago by Vladislav Kaznacheev
Modified:
9 years, 1 month ago
Reviewers:
Oleg Eterevsky
CC:
Peter Mayo, chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Fixing FileManagerDialogBrowserTest Commented out a line that reliably fails the tests, although the real cause seems to be chromium:101665. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/file_manager/js/metadata_dispatcher.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Vladislav Kaznacheev
Please review.
9 years, 1 month ago (2011-10-27 15:34:43 UTC) #1
Oleg Eterevsky
LGTM
9 years, 1 month ago (2011-10-27 15:35:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8363054/1
9 years, 1 month ago (2011-10-27 15:36:20 UTC) #3
Vladislav Kaznacheev
Sent to a submit queue. This fixes the four FileManagerDialogBrowserTest.* tests.
9 years, 1 month ago (2011-10-27 15:38:23 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-27 16:51:54 UTC) #5
Change committed as 107588

Powered by Google App Engine
This is Rietveld 408576698