Issue 8363043: Fix the const of HasFocus for aura.

Issue 8363043: Fix the const of HasFocus for aura. (Closed)

Created:
9 years, 1 month ago by Peter Mayo

Modified:
9 years, 1 month ago

Reviewers:
Peter Kasting, Hironori Bono

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, jam, dpranke-watch+content_chromium.org, Hironori Bono

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fix the const of HasFocus for aura. BUG=chromium:101879 TEST=trybots DUP=http://codereview.chromium.org/8402022

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_aura.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

lgtm LGTM with a nit. Thank you so much for your fix. Regards, Hironori Bono ...

9 years, 1 month ago (2011-10-27 10:51:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/8363043/1

9 years, 1 month ago (2011-10-27 10:52:02 UTC) #3

commit-bot: I haz the power

Can't apply patch for file content/browser/renderer_host/render_widget_host_view_aura.cc. While running patch -p0 --forward --force; patching file content/browser/renderer_host/render_widget_host_view_aura.cc ...

9 years, 1 month ago (2011-10-27 10:52:03 UTC) #4

Peter Mayo

http://codereview.chromium.org/8363043/diff/1/content/browser/renderer_host/render_widget_host_view_aura.h File content/browser/renderer_host/render_widget_host_view_aura.h (right): http://codereview.chromium.org/8363043/diff/1/content/browser/renderer_host/render_widget_host_view_aura.h#newcode47 content/browser/renderer_host/render_widget_host_view_aura.h:47: virtual bool HasFocus() OVERRIDE const; On 2011/10/27 10:51:30, hbono ...

9 years, 1 month ago (2011-10-27 10:54:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/8363043/1004

9 years, 1 month ago (2011-10-27 10:55:02 UTC) #6

commit-bot: I haz the power

9 years, 1 month ago (2011-10-27 10:55:03 UTC) #7

Peter Mayo

9 years, 1 month ago (2011-10-27 11:02:13 UTC) #8

On 2011/10/27 10:55:03, I haz the power (commit-bot) wrote:
> Can't apply patch for file
> content/browser/renderer_host/render_widget_host_view_aura.cc.
> While running patch -p0 --forward --force;
> patching file content/browser/renderer_host/render_widget_host_view_aura.cc
> Hunk #1 FAILED at 111.
> 1 out of 1 hunk FAILED -- saving rejects to file
> content/browser/renderer_host/render_widget_host_view_aura.cc.rej

http://codereview.chromium.org/8402022

Expand Messages | Collapse Messages