Refactor the "spell-checker options" submenu.

Refactor the "spell-checker options" submenu.
This change adds a SpellCheckSubMenuObserver class and move code of the "spell-checker options" submenu there.

BUG=93746
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107698

[Hironori Bono, 2011-10-27 09:04:06]

Greetings Avi,

This change just tries splitting the RenderViewContextMenu class with new
classes (RenderViewContextMenuObserver and RenderViewContextMenuProxy). Even
though I prefer splitting this class into pieces, I'm wondering if everyone
likes it. Is it possible to give me your thoughts?

Regards,

Hironori Bono

[Avi (use Gerrit), 2011-10-27 12:40:02]

lgtm

http://codereview.chromium.org/8363042/diff/7008/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/render_view_context_menu.h (right):

http://codereview.chromium.org/8363042/diff/7008/chrome/browser/tab_contents/...
chrome/browser/tab_contents/render_view_context_menu.h:266: // An observer that
handles a 'spell-cheker options' submenu.
s/cheker/checker/

http://codereview.chromium.org/8363042/diff/7008/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/spellchecker_submenu_observer.cc (right):

http://codereview.chromium.org/8363042/diff/7008/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spellchecker_submenu_observer.cc:40: //
intended blank comment?

[commit-bot: I haz the power, 2011-10-28 07:02:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hbono@chromium.org/8363042/9001

[Hironori Bono, 2011-10-28 07:14:09]

Greetings Avi,

Thank you for your review and comments. I'm happy to see you like this change.

Regards,

Hironori Bono

http://codereview.chromium.org/8363042/diff/7008/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/render_view_context_menu.h (right):

http://codereview.chromium.org/8363042/diff/7008/chrome/browser/tab_contents/...
chrome/browser/tab_contents/render_view_context_menu.h:266: // An observer that
handles a 'spell-cheker options' submenu.
On 2011/10/27 12:40:03, Avi wrote:
> s/cheker/checker/

Done.

http://codereview.chromium.org/8363042/diff/7008/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/spellchecker_submenu_observer.cc (right):

http://codereview.chromium.org/8363042/diff/7008/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spellchecker_submenu_observer.cc:40: //
On 2011/10/27 12:40:03, Avi wrote:
> intended blank comment?

Done.

[commit-bot: I haz the power, 2011-10-28 08:08:28]

Change committed as 107698