Issue 8363041: top sites: re-enable test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8363041: top sites: re-enable test (Closed)

Created:
9 years, 1 month ago by Evan Stade

Modified:
9 years, 1 month ago

Reviewers:
vandebo (ex-Chrome), mihaip

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

top sites: re-enable test if TopSites hasn't loaded, the ExtensionFunction returns asynchronously, which RunFunctionAndReturnResult can't handle BUG=101783 TEST=self Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108035

Patch Set 1 #

Total comments: 1

Patch Set 2 : change var name and fix a TODO #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -15 lines)			Patch
	M	chrome/browser/history/top_sites_extension_test.cc	View	1	3 chunks	+41 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

LGTM with nit. http://codereview.chromium.org/8363041/diff/1/chrome/browser/history/top_sites_extension_test.cc File chrome/browser/history/top_sites_extension_test.cc (right): http://codereview.chromium.org/8363041/diff/1/chrome/browser/history/top_sites_extension_test.cc#newcode24 chrome/browser/history/top_sites_extension_test.cc:24: history::TopSites* ts = browser()->profile()->GetTopSites(); nit: full ...

9 years, 1 month ago (2011-10-27 23:11:44 UTC) #2

mihaip_google.com

9 years, 1 month ago (2011-10-28 21:35:19 UTC) #3

On Wed, Oct 26, 2011 at 7:25 PM, <estade@chromium.org> wrote:

> if TopSites hasn't loaded, the ExtensionFunction returns asynchronously,
> which
> RunFunctionAndReturnResult can't handle
>

Aaron: any ideas for handling async functions in tests better?

Mihai

Expand Messages | Collapse Messages