Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: client/html/src/WindowWrappingImplementation.dart

Issue 8363040: Implement measurement using futures (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Respond to all comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/html/src/WindowWrappingImplementation.dart
diff --git a/client/html/src/WindowWrappingImplementation.dart b/client/html/src/WindowWrappingImplementation.dart
index aeaa5c291410fa34eedf253bb0b9dc200d068862..630b9adeeab515c494627092dc81834c360db3f2 100644
--- a/client/html/src/WindowWrappingImplementation.dart
+++ b/client/html/src/WindowWrappingImplementation.dart
@@ -688,21 +688,6 @@ class WindowWrappingImplementation extends EventTargetWrappingImplementation imp
_ptr.focus();
}
- CSSStyleDeclaration getComputedStyle([Element element = null, String pseudoElement = null]) {
- if (element === null) {
- if (pseudoElement === null) {
- return LevelDom.wrapCSSStyleDeclaration(_ptr.getComputedStyle());
- }
- } else {
- if (pseudoElement === null) {
- return LevelDom.wrapCSSStyleDeclaration(_ptr.getComputedStyle(LevelDom.unwrap(element)));
- } else {
- return LevelDom.wrapCSSStyleDeclaration(_ptr.getComputedStyle(LevelDom.unwrap(element), pseudoElement));
- }
- }
- throw "Incorrect number or type of arguments";
- }
-
DOMSelection getSelection() {
return LevelDom.wrapDOMSelection(_ptr.getSelection());
}
@@ -792,19 +777,8 @@ class WindowWrappingImplementation extends EventTargetWrappingImplementation imp
return _ptr.setInterval(handler, timeout);
}
- int setTimeout([TimeoutHandler handler = null, int timeout = null]) {
- if (handler === null) {
- if (timeout === null) {
- return _ptr.setTimeout();
- }
- } else {
- if (timeout === null) {
- return _ptr.setTimeout(handler);
- } else {
- return _ptr.setTimeout(handler, timeout);
- }
- }
- throw "Incorrect number or type of arguments";
+ int setTimeout(TimeoutHandler handler, int timeout) {
nweiz 2011/10/28 03:58:38 Style nit: =>
Jacob 2011/10/31 22:09:50 Done.
+ return _ptr.setTimeout(handler, timeout);
}
Object showModalDialog(String url, [Object dialogArgs = null, String featureArgs = null]) {
@@ -865,10 +839,15 @@ class WindowWrappingImplementation extends EventTargetWrappingImplementation imp
if (element === null) {
return _ptr.webkitRequestAnimationFrame(callback);
} else {
- return _ptr.webkitRequestAnimationFrame(callback, LevelDom.unwrap(element));
+ return _ptr.webkitRequestAnimationFrame(
+ callback, LevelDom.unwrap(element));
}
}
+ void requestLayoutFrame(TimeoutHandler callback) {
+ _addMeasurementFrameCallback(callback);
+ }
+
WindowEvents get on() {
if (_on === null) {
_on = new WindowEventsImplementation._wrap(_ptr);

Powered by Google App Engine
This is Rietveld 408576698