Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: client/touch/ScrollWatcher.dart

Issue 8363040: Implement measurement using futures (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: take2 Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/touch/ScrollWatcher.dart
diff --git a/client/touch/ScrollWatcher.dart b/client/touch/ScrollWatcher.dart
index 603d34c731b870688c9516b569a7262e7a5eb5f4..ff23a9622f5e6aee505ef498c315edd3afd49392 100644
--- a/client/touch/ScrollWatcher.dart
+++ b/client/touch/ScrollWatcher.dart
@@ -14,22 +14,18 @@ interface ScrollListener {
/**
* The scroll watcher is intended to provide a single way to
- * listen for scroll events from instances of Scroller, abstracting the
- * various nuances between momentum strategies that require different scroll
- * listening strategies.
+ * listen for scroll events from instances of Scroller.
+ * TODO(jacobr): this class is obsolete.
*/
class ScrollWatcher {
Scroller _scroller;
List<ScrollListener> _listeners;
- TimeoutHandler _boundOnDecel;
Element _scrollerEl;
- int _decelIntervalId;
ScrollWatcher(Scroller scroller)
: _scroller = scroller, _listeners = new List<ScrollListener>() {
- _boundOnDecel = () { _onDecelerate(); };
}
void addListener(ScrollListener listener) {
@@ -64,38 +60,4 @@ class ScrollWatcher {
num scrollY = _scroller.getVerticalOffset();
_dispatchScroll(scrollX, scrollY);
}
-
- /**
- * This callback is invoked every 30ms while deceleration is happening.
- */
- void _onDecelerate() {
- final transform = StyleUtil.getCurrentTransformMatrix(_scrollerEl);
- num scrollX = transform.m41;
- num scrollY = transform.m42;
- _dispatchScroll(scrollX, scrollY, true);
- }
-
- /**
- * When deceleration begins, clear the interval if it already exists and set
- * up a new one.
- */
- void _onDecelerationStart(Event e) {
- if (_decelIntervalId !== null) {
- window.clearInterval(_decelIntervalId);
- }
- // TODO(jacobr): use Env.requestAnimationFrame and renable this.
- // Right now this would kill our performance and is not relevant given
- // we are using timeout based momentum.
- // _decelIntervalId = window.setInterval(_boundOnDecel, 30);
- }
-
- /**
- * When scrolling ends, clear the interval if it exists.
- */
- void _onScrollerEnd(Event e) {
- if (_decelIntervalId !== null) {
- window.clearInterval(_decelIntervalId);
- }
- _onContentMoved(e);
- }
}

Powered by Google App Engine
This is Rietveld 408576698