Implement measurement using futures

client/samples/total/src/SpreadsheetPresenter.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 typedef void EditCellRangeFunction(CellRange range);
 
 /**
  * Spreadsheet widget.
  */
 class SpreadsheetPresenter implements SpreadsheetListener, SelectionListener {
@@ skipping 656 matching lines @@
     _moveDragger.style.setProperty("left", HtmlUtils.toPx(3));
     _moveDragger.style.setProperty("top", HtmlUtils.toPx(3));
     _spreadsheetElement.nodes.add(_moveDragger);
 
     _moveDragger.on.mouseDown.add((MouseEvent e) {
       _moveToTop();
       _hideInnerMenu(true);
 
       int mouseStartX = e.x;
       int mouseStartY = e.y;
-      ClientRect rect = _spreadsheetElement.getBoundingClientRect();
-      int startX = rect.left;
-      int startY = rect.top;
-      _window.document.body.style.setProperty("cursor", "move");
 
-      _setDragFunction((MouseEvent e) {
-        int x = startX + e.x - mouseStartX;
-        int y = startY + e.y - mouseStartY;
+      _spreadsheetElement.rect.then((ElementRect elementRect) {
+        ClientRect rect = elementRect.bounding;
+        int startX = rect.left;
+        int startY = rect.top;
+        _window.document.body.style.setProperty("cursor", "move");
 
-        x = Math.max(x, CssStyles.OBJECTBAR_WIDTH);
-        y = Math.max(y, CssStyles.SANDBAR_HEIGHT);
-        // Move the spreadsheet container
-        _spreadsheetElement.style.setProperty("left", HtmlUtils.toPx(x));
-        _spreadsheetElement.style.setProperty("top", HtmlUtils.toPx(y));
-      });
+        _setDragFunction((MouseEvent e) {
+          int x = startX + e.x - mouseStartX;

[arv (Not doing code reviews), 2011/10/27 05:50:24]

e.x? We should kill that property... in another CL

[Jacob, 2011/10/27 20:59:25]

Agreed. Can't wait till we cleanup the event classes.

+          int y = startY + e.y - mouseStartY;
+
+          x = Math.max(x, CssStyles.OBJECTBAR_WIDTH);
+          y = Math.max(y, CssStyles.SANDBAR_HEIGHT);
+          // Move the spreadsheet container
+          _spreadsheetElement.style.setProperty("left", HtmlUtils.toPx(x));
+          _spreadsheetElement.style.setProperty("top", HtmlUtils.toPx(y));
+        });
+        });
 
       _setUndragFunction((MouseEvent e) {
         _window.document.body.style.setProperty("cursor", "auto");
       });
     });
   }
 
   void _createResizeDragger(Document doc) {
     _resizeDragger = doc.createElement("div");
     _resizeDragger.id = "resizeDragger-${_spreadsheet.name}";
@@ skipping 175 matching lines @@
 
     // apply text selection now
     _formulaCellSelectingSelectText();
 
     // show cell selecting div
     {
       DivElement div = _table.formulaCellSelectingDiv;
       CSSStyleDeclaration divStyle = div.style;
       int borderWidth = 2 + 2;
       CellRange cellRange = new CellRange(_spreadsheet, minCorner, maxCorner);
-      BoundingBox box = _selectionManager.getBoundingBoxForRange(cellRange);
-      if (box != null) {
-        divStyle.setProperty("left", HtmlUtils.toPx(box.left));
-        divStyle.setProperty("top", HtmlUtils.toPx(box.top));
-        divStyle.setProperty("width", HtmlUtils.toPx(box.width - borderWidth));
-        divStyle.setProperty("height", HtmlUtils.toPx(box.height - borderWidth));
-        divStyle.removeProperty("display");
-      } else {
-        divStyle.setProperty("display", "none");
-      }
+      _selectionManager.getBoundingBoxForRange(cellRange).then(
+          (BoundingBox box) {
+        if (box != null) {
+          divStyle.setProperty("left", HtmlUtils.toPx(box.left));

[arv (Not doing code reviews), 2011/10/27 05:50:24]

Is there a reason why we don't do divStyle.left = ...?

[Jacob, 2011/10/27 20:59:25]

Only historical reasons.

I'll do a separate CL that regexp replaces all existing uses of setProperty 
now that Nathan's CL merging Css.dart directly into CSSStyleDeclaration has
landed.

+          divStyle.setProperty("top", HtmlUtils.toPx(box.top));
+          divStyle.setProperty("width", HtmlUtils.toPx(box.width - borderWidth));
+          divStyle.setProperty("height", HtmlUtils.toPx(box.height - borderWidth));
+          divStyle.removeProperty("display");
+        } else {
+          divStyle.setProperty("display", "none");
+        }
+      });
     }
   }
 
   void _formulaCellSelectingRememberSelectionRange() {
     _formulaCellSelectingTextStart = _formulaInput.selectionStart;
     _formulaCellSelectingTextEnd = _formulaInput.selectionEnd;
   }
 
   void _formulaCellSelectingSelectText() {
     _formulaInput.focus();
@@ skipping 155 matching lines @@
 
   // Return the number of _rows currently being displayed (not counting the column header row)
   int _getVisibleTableHeight() => _getShiftedRowEnd(_rowShift + _rows, _rowShift);
 
   // Return the number of _columns currently being displayed (not counting the row header column)
   int _getVisibleTableWidth() => _getShiftedColumnEnd(_columnShift + _columns, _columnShift);
 
   // Resize the formula input field to fit the contained text
   void _growFormulaInput() {
     _formulaInputMeasure.text = _formulaInput.value;
-    int textWidth = _formulaInputMeasure.clientWidth;
-    int width = Math.max(textWidth + 25, _formulaCellWidth);
-    _formulaDiv.style.setProperty("width", HtmlUtils.toPx(width));
-    _formulaInput.style.setProperty("width", HtmlUtils.toPx(width));
+    _formulaInputMeasure.rect.then((ElementRect rect) {
+      int textWidth = rect.client.width;
+      int width = Math.max(textWidth + 25, _formulaCellWidth);
+      _formulaDiv.style.setProperty("width", HtmlUtils.toPx(width));
+      _formulaInput.style.setProperty("width", HtmlUtils.toPx(width));
+      });
   }
 
   // Fade out the formula input field
   void _hideFormula() {
     _hideFormulaCellSelecting();
     _formulaEditing = false;
     _formulaDiv.classes.remove("fadeIn");
     _formulaDiv.classes.add("fadeOut");
   }
 
@@ skipping 47 matching lines @@
   // update table row and column headers
   void _redrawHeaders() {
     _setTableWidth(_getVisibleTableWidth());
     _tableSizeChanged();
 
     _table.redrawHeaders(_selectionManager, _rows, _columns, _rowShift, _columnShift,
         _cellDisplay);
   }
 
   void _refreshResizeDragger() {
-    // We may be called before the dragger is ready
-    if (_resizeDragger == null) {
-      return;
-    }
-    ClientRect rect = _table.getBoundingClientRect();
+    _table.rect.then((ElementRect elementRect) {
+      // We may be called before the dragger is ready
+      if (_resizeDragger == null) {
+        return;
+      }
+      ClientRect rect = elementRect.bounding;
 
-    _resizeDragger.style.setProperty("left", HtmlUtils.toPx(rect.width));
-    _resizeDragger.style.setProperty("top", HtmlUtils.toPx(rect.height));
+      _resizeDragger.style.setProperty("left", HtmlUtils.toPx(rect.width));
+      _resizeDragger.style.setProperty("top", HtmlUtils.toPx(rect.height));
+    });
   }
 
   // Remove the HTML elements corresponding to the given column
   void _removeTableColumnHtml(int col) {
     _table.removeColumn(col);
     int width = _spreadsheet.getColumnWidth(col);
     _setTableWidth(_tableWidth - width);
   }
 
   // Remove the HTML elements corresponding to the given row
@@ skipping 120 matching lines @@
 
     List<int> draggingRowColumn = new List<int>(2);
     draggingRowColumn[COL] = -1;
     draggingRowColumn[ROW] = -1;
 
     int oldSize;
     int start;
     int x;
     int y;
 
-    // Set x and y to the mouse coordinates, relative to the top left of the spreadsheet table
-    void getRelativeCoordinates(MouseEvent e) {
-      ClientRect boundingRect = _table.getBoundingClientRect();
-      int scrollOffsetX = -boundingRect.left.toInt();
-      int scrollOffsetY = -boundingRect.top.toInt();
-      x = e.x + scrollOffsetX;
-      y = e.y + scrollOffsetY;
-    }
-
     // Sets the drag indicator to the given position, given as an absolute offset from
     // the upper-left corner of the spreadsheet
     void setDragPosition(int rowOrCol, int pos) {
       if (rowOrCol == COL) {
         pos -= _spreadsheet.getColumnShift(_columnShift);
         _dragIndicators[COL].style.setProperty("left", HtmlUtils.toPx(pos));
       } else {
         pos -= _spreadsheet.getRowShift(_rowShift);
         // need to shift for the inner menu offset
         pos += _getInnerMenuOffset(hoverRowColumn[ROW]);
@@ skipping 150 matching lines @@
         setDrag(COL, false);
       }
     });
 
     // The inline cell editing UI is displayed when a user makes the same single
     // cell selection over again. We keep track of the current single cell that
     // is selected here to know when to enter edit mode.
     CellLocation currentSelectedSingleCell = null;
 
     void mouseMove(MouseEvent e) {
-      getRelativeCoordinates(e);
+      _table.rect.then((ElementRect rect) {
+        // Set x and y to the mouse coordinates, relative to the top left of
+        // the spreadsheet table.
+        ClientRect boundingRect = rect.bounding;
+        int scrollOffsetX = -boundingRect.left.toInt();
+        int scrollOffsetY = -boundingRect.top.toInt();
+        x = e.x + scrollOffsetX;
+        y = e.y + scrollOffsetY;
 
-      // Update the dragger position and optionally the actual row/column size
-      if (dragRowColumn(false)) {
-        return;
-      }
+        // Update the dragger position and optionally the actual row/column size
+        if (dragRowColumn(false)) {
+          return;
+        }
 
-      // Show a row/column dragging indicator when hovering over row/column 0
-      if (x < _spreadsheet.getColumnWidth(0) && x > 0) {
-        hoverRowColumn[ROW] = _getRowOrColumn(y, ROW);
-      } else {
-        hoverRowColumn[ROW] = -1;
-      }
-      if (y < _spreadsheet.getRowHeight(0) && y > 0) {
-        hoverRowColumn[COL] = _getRowOrColumn(x, COL);
-      } else {
-        hoverRowColumn[COL] = -1;
-      }
-      if (hoverRowColumn[COL] != -1) {
-        hoverRowColumn[ROW] = -1;
-        setDrag(COL, true);
-        setDrag(ROW, false);
-      } else {
-        setDrag(COL, false);
-        if (hoverRowColumn[ROW] != -1) {
-          setDrag(ROW, true);
+        // Show a row/column dragging indicator when hovering over row/column 0
+        if (x < _spreadsheet.getColumnWidth(0) && x > 0) {
+          hoverRowColumn[ROW] = _getRowOrColumn(y, ROW);
         } else {
+          hoverRowColumn[ROW] = -1;
+        }
+        if (y < _spreadsheet.getRowHeight(0) && y > 0) {
+          hoverRowColumn[COL] = _getRowOrColumn(x, COL);
+        } else {
+          hoverRowColumn[COL] = -1;
+        }
+        if (hoverRowColumn[COL] != -1) {
+          hoverRowColumn[ROW] = -1;
+          setDrag(COL, true);
           setDrag(ROW, false);
+        } else {
+          setDrag(COL, false);
+          if (hoverRowColumn[ROW] != -1) {
+            setDrag(ROW, true);
+          } else {
+            setDrag(ROW, false);
+          }
         }
-      }
-      if (hoverRowColumn[COL] != -1) {
-        _table.setColResizeCursor();
-      } else if (hoverRowColumn[ROW] != -1) {
-        _table.setRowResizeCursor();
-      } else {
-        _table.setCellCursor();
-      }
+        if (hoverRowColumn[COL] != -1) {
+          _table.setColResizeCursor();
+        } else if (hoverRowColumn[ROW] != -1) {
+          _table.setRowResizeCursor();
+        } else {
+          _table.setCellCursor();
+        }
 
-      // If dragging a selections, update the selection's second corner
-      if (!draggingSelection) {
-        return;
-      }
-      Element target = e.target;
-      CellLocation location = _getCellLocation(target);
-      if (location == null) {
-        return;
-      }
-      _selectionManager.selectionCorner = location;
-      // If the drag has selected more than one cell then we no longer
-      // have a current single cell selection.
-      if (!_selectionManager.isSingleCellSelection()) {
-        currentSelectedSingleCell = null;
-      }
-      _selectionManager.updateSelection();
-      _redrawHeaders();
+        // If dragging a selections, update the selection's second corner
+        if (!draggingSelection) {
+          return;
+        }
+        Element target = e.target;
+        CellLocation location = _getCellLocation(target);
+        if (location == null) {
+          return;
+        }
+        _selectionManager.selectionCorner = location;
+        // If the drag has selected more than one cell then we no longer
+        // have a current single cell selection.
+        if (!_selectionManager.isSingleCellSelection()) {
+          currentSelectedSingleCell = null;
+        }
+        _selectionManager.updateSelection();
+        _redrawHeaders();
+      });
     }
 
     _setMove(mouseMove);
 
     _table.on.mouseDown.add((MouseEvent e) {
       _moveToTop();
 
       // Right click toggles and positions the context menu
       if (e.button == 2 || (e.button == 0 && e.ctrlKey)) {
-        ClientRect boundingRect = _table.getBoundingClientRect();
-        int scrollOffsetX = -boundingRect.left;
-        int scrollOffsetY = -boundingRect.top;
-        _contextMenu.show(e.x + scrollOffsetX, e.y + scrollOffsetY);
+        _table.rect.then((ElementRect rect) {
+          ClientRect boundingRect = rect.bounding;
+          int scrollOffsetX = -boundingRect.left;
+          int scrollOffsetY = -boundingRect.top;
+          _contextMenu.show(e.x + scrollOffsetX, e.y + scrollOffsetY);
+        });
         return;
       }
 
       _setDragFunction(mouseMove);
 
       _setUndragFunction((MouseEvent e) {
         dragRowColumn(true);
         _table.setDefaultCursor();
         draggingSelection = false;
         draggingRowColumn[COL] = -1;
@@ skipping 120 matching lines @@
     }
     _activeInnerMenu = new InnerMenuView(_window, row, _selectionManager, style,
         _spreadsheet.layout.getRowHeight(rowIndex),
         (){ _tableSizeChanged(); },
         (){ _hideInnerMenu(true); _repositionFormulaInput(null, false); });
     _innerMenuRowIndex = rowIndex;
   }
 
   // Update the scroll mechanism due to a change in the visible table area
   void _tableSizeChanged() {
-    ClientRect rect = _table.getBoundingClientRect();
+    _table.rect.then((ElementRect elementRect) {
+      ClientRect rect = elementRect.bounding;
 
-    _tableScrollContainer.style.setProperty("width", HtmlUtils.toPx(rect.width + 10));
-    _spreadsheetElement.style.setProperty("width", HtmlUtils.toPx(rect.width));
+      _tableScrollContainer.style.setProperty("width", HtmlUtils.toPx(rect.width + 10));

[arv (Not doing code reviews), 2011/10/27 05:50:24]

long lines

[Jacob, 2011/10/27 20:59:25]

Done.

+      _spreadsheetElement.style.setProperty("width", HtmlUtils.toPx(rect.width));
 
-    _tableScrollContainer.style.setProperty("height", HtmlUtils.toPx(rect.height + 10));
-    _spreadsheetElement.style.setProperty("height", HtmlUtils.toPx(rect.height));
+      _tableScrollContainer.style.setProperty("height", HtmlUtils.toPx(rect.height + 10));
+      _spreadsheetElement.style.setProperty("height", HtmlUtils.toPx(rect.height));
 
-    _tableScrollDiv.style.setProperty("width", 
-        HtmlUtils.toPx(_spreadsheet.getColumnEnd(_spreadsheet.columnCount())));
-    int extra = _activeInnerMenu == null ? 0 : _activeInnerMenu.currentRowHeight;
-    _tableScrollDiv.style.setProperty("height",
-        HtmlUtils.toPx(_spreadsheet.getRowEnd(_spreadsheet.rowCount()) + extra));
+      _tableScrollDiv.style.setProperty("width", 
+          HtmlUtils.toPx(_spreadsheet.getColumnEnd(_spreadsheet.columnCount())));
+      int extra = _activeInnerMenu == null ? 0 : _activeInnerMenu.currentRowHeight;
+      _tableScrollDiv.style.setProperty("height",
+          HtmlUtils.toPx(_spreadsheet.getRowEnd(_spreadsheet.rowCount()) + extra));
 
-    // Reposition the scroll bars
-    _scroll(_rowShift, _columnShift);
-    // Move the resize dragger to the bottom-right corner
-    _refreshResizeDragger();
+      // Reposition the scroll bars
+      _scroll(_rowShift, _columnShift);
+      // Move the resize dragger to the bottom-right corner
+      _refreshResizeDragger();
+    });
   }
 
   void _updateInnerMenu() {
     if (_activeInnerMenu != null) {
       _activeInnerMenu.updateSize();
     }
   }
 
   // Change the width/height of a column or row.
   void _updateRowColumnSize(int rowOrCol, int index, int size, int oldSize, bool mouseUp) {
     if (mouseUp) {
       Command command = new ResizeRowColumnCommand(_spreadsheet, rowOrCol, index, size, oldSize);
       _spreadsheet.execute(command);
     } else {
       if (rowOrCol == COL) {
         _spreadsheet.setColumnWidth(index, size);
       } else {
         _spreadsheet.setRowHeight(index, size);
       }
     }
   }
 }