Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: chrome/browser/web_resource/promo_resource_service.h

Issue 8363035: NTP4/Sync Promo: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged, fixed, unit tests and quick smoke test passing Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/promo_resource_service.h
diff --git a/chrome/browser/web_resource/promo_resource_service.h b/chrome/browser/web_resource/promo_resource_service.h
index fd974253f3b95262a771cb7f4197eaad8035c65e..c9b2b7b2a5b0d300afb9d4d0c5ea902a12ad40b1 100644
--- a/chrome/browser/web_resource/promo_resource_service.h
+++ b/chrome/browser/web_resource/promo_resource_service.h
@@ -44,8 +44,8 @@ class PromoResourceService
// Checks for conditions to show promo: start/end times, channel, etc.
static bool CanShowNotificationPromo(Profile* profile);
- // Checks if this user is in a group for sync promo roll-out.
- static bool CanShowSyncPromo(Profile* profile);
+ // Checks if this user is in a group for sign-in promo roll-out.
+ static bool CanShowNTPSignInPromo(Profile* profile);
static void RegisterPrefs(PrefService* local_state);
@@ -60,7 +60,7 @@ class PromoResourceService
static const char* kDefaultPromoResourceServer;
private:
- friend class SyncPromoTest;
+ friend class NTPSignInPromoTest;
FRIEND_TEST_ALL_PREFIXES(PromoResourceServiceTest, IsBuildTargetedTest);
FRIEND_TEST_ALL_PREFIXES(PromoResourceServiceTest, UnpackLogoSignal);
FRIEND_TEST_ALL_PREFIXES(PromoResourceServiceTest, UnpackWebStoreSignal);
@@ -209,22 +209,21 @@ class PromoResourceService
// answer_id: the promo's id
void UnpackWebStoreSignal(const base::DictionaryValue& parsed_json);
- // Unpack the sync promo. Expects JSON delivery in the following format:
+ // Unpack the NTP sign in promo. Expects JSON in the following format:
// {
// "topic": {
// "answers": [
// ...
// {
// "answer_id": "XXXXXXX",
- // "name": "sync_promo",
+ // "name": "sign_in_promo",
// "question": "1:5"
// }
// ]
// }
// }
- //
// The question is in the form of "<build>:<group_max>".
- void UnpackSyncPromoSignal(const base::DictionaryValue& parsed_json);
+ void UnpackNTPSignInPromoSignal(const base::DictionaryValue& parsed_json);
// NotificationPromo::Delegate override.
virtual void OnNewNotification(double start, double end) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698