Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 8363030: Improve pylint error message with an old version is used. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Improve pylint error message with an old version is used. Instead of crashing, prints an error message. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106867

Patch Set 1 #

Patch Set 2 : Better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M presubmit_canned_checks.py View 3 chunks +7 lines, -4 lines 0 comments Download
M pylintrc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-21 16:11:01 UTC) #1
Dirk Pranke
lgtm
9 years, 2 months ago (2011-10-21 21:15:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8363030/3
9 years, 2 months ago (2011-10-23 00:14:05 UTC) #3
commit-bot: I haz the power
Presubmit check for 8363030-3 failed and returned exit status 1. svn: Could not open the ...
9 years, 2 months ago (2011-10-23 00:18:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8363030/3
9 years, 2 months ago (2011-10-23 00:30:21 UTC) #5
commit-bot: I haz the power
Change committed as 106867
9 years, 2 months ago (2011-10-23 00:35:59 UTC) #6
M-A Ruel
9 years, 2 months ago (2011-10-23 00:38:31 UTC) #7
On 2011/10/23 00:18:44, I haz the power (commit-bot) wrote:
> Failed to sync rietveld
> Command svn up -q -r 681 returned non-zero exit status 1 in
> /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/_rietveld

Looks like google code failure, since the presubmit check was checking out
rietveld from google code with svn and it passed the next time.

Powered by Google App Engine
This is Rietveld 408576698