Igonre closure classes when looking for duplication.

runtime/vm/object.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "vm/assembler.h"
 #include "vm/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 3688 matching lines @@
   Object& obj = Object::Handle();
   Class& cls = Class::Handle();
   Function& func = Function::Handle();
   Field& field = Field::Handle();
   String& entry_name = String::Handle();
   while (it.HasNext()) {
     obj = it.GetNext();
     ASSERT(!obj.IsNull());
     if (obj.IsClass()) {
       cls ^= obj.raw();
+      if (cls.IsSignatureClass()) {
+        continue;
+      }

[siva, 2011/10/21 17:20:47]

I think this is not the right fix, imagine the case:
library1.dart has
typedef void callBackType(int param1, int param2);
and
library2.dart has
typedef int callBackType();

now we import these two into an app as
import library1.dart
import library2.dart
then we should get a duplicate definition error.

With this change I think we won't get an error.

[Anton Muhin, 2011/10/21 17:34:26]

Thanks a lot, Siva.  Sounds like you're right.  I'll investigate if you don't
mind.

On 2011/10/21 17:20:47, asiva wrote:

[siva, 2011/10/21 18:13:37]

Anton, see the updates done in issue 187. Regis and I were discussing this and
we concluded that the implicit signature classes were being added at the wrong
place.

On 2011/10/21 17:34:26, antonmuhin wrote:

       entry_name = cls.Name();
     } else if (obj.IsFunction()) {
       func ^= obj.raw();
       entry_name = func.name();
     } else if (obj.IsField()) {
       field ^= obj.raw();
       entry_name = field.name();
     } else {
       // We don't check for library prefixes defined in this library because
       // they are not visible in the importing scope and hence cannot
@@ skipping 2966 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart