Check for XInput2 for touchui and aura bots.

Check for XInput2 for touchui and aura bots.

BUG=101061
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106652

[sadrul, 2011-10-20 20:49:58]

I took the liberty of changing from printf to fprintf(stderr

[Emmanuel Saint-loubert-Bié, 2011-10-20 20:54:17]

lgtm

[Peter Mayo, 2011-10-20 20:58:28]

http://codereview.chromium.org/8363012/diff/2001/tools/xdisplaycheck/xdisplay...
File tools/xdisplaycheck/xdisplaycheck.cc (right):

http://codereview.chromium.org/8363012/diff/2001/tools/xdisplaycheck/xdisplay...
tools/xdisplaycheck/xdisplaycheck.cc:17: #include <X11/extensions/XInput2.h>
Does this not want to be wrapped in if defined() too?

[tony, 2011-10-20 21:19:49]

lgtm

http://codereview.chromium.org/8363012/diff/2001/tools/xdisplaycheck/xdisplay...
File tools/xdisplaycheck/xdisplaycheck.cc (right):

http://codereview.chromium.org/8363012/diff/2001/tools/xdisplaycheck/xdisplay...
tools/xdisplaycheck/xdisplaycheck.cc:17: #include <X11/extensions/XInput2.h>
On 2011/10/20 20:58:28, Peter Mayo wrote:
> Does this not want to be wrapped in if defined() too?

If the package is pulled in by install-build-deps.sh, then this should be fine.

[sadrul, 2011-10-20 21:42:38]

http://codereview.chromium.org/8363012/diff/2001/tools/xdisplaycheck/xdisplay...
File tools/xdisplaycheck/xdisplaycheck.cc (right):

http://codereview.chromium.org/8363012/diff/2001/tools/xdisplaycheck/xdisplay...
tools/xdisplaycheck/xdisplaycheck.cc:17: #include <X11/extensions/XInput2.h>
On 2011/10/20 21:19:49, tony wrote:
> On 2011/10/20 20:58:28, Peter Mayo wrote:
> > Does this not want to be wrapped in if defined() too?
> 
> If the package is pulled in by install-build-deps.sh, then this should be
fine.

I think it does. But added the check anyway to be sure.

[Peter Mayo, 2011-10-20 21:58:30]

lgtm

[sadrul, 2011-10-20 22:05:27]

Is it safe to just go ahead and land this, or do I need to coordinate with the
troopers?

[Peter Mayo (wrong one), 2011-10-20 22:08:12]

I believe it is as safe as any other change that is common to an entire
platform.

If it breaks ... much will go red and it will get reverted.

Have you tested?  tried on linux and linux_touch and linux_aura?


(I am just about to fix the linux_aura :  it might be interesting to look at
the unfixed result)


On Thu, Oct 20, 2011 at 6:05 PM, <sadrul@chromium.org> wrote:

> Is it safe to just go ahead and land this, or do I need to coordinate with
> the
> troopers?
>
>
http://codereview.chromium.**org/8363012/<http://codereview.chromium.org/8363...
>



-- 

Peter Mayo | Tangent | petermayo@google.com | 519-880-3439