runtime/vm/thread_macos.cc - Issue 8362026: Fixed a problem with spurious wakeups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_macos.cc

Issue 8362026: Fixed a problem with spurious wakeups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/thread_macos.cc

diff --git a/runtime/vm/thread_macos.cc b/runtime/vm/thread_macos.cc

index 93aba9f94eb1430e15959c2ad63cb7faca89906a..1d1fe65f6a5dc44205de002e96ccd4a42905c736 100644

--- a/runtime/vm/thread_macos.cc

+++ b/runtime/vm/thread_macos.cc

@@ -193,6 +193,8 @@ Monitor::WaitResult Monitor::Wait(int64_t millis) {

Monitor::WaitResult retval = kNotified;

if (millis == 0) {

// Wait forever.

+ // If the thread receives a signal, pthread_cond_wait may return 0,

+ // because of a spurious wakeup.

int result = pthread_cond_wait(data_.cond(), data_.mutex());

VALIDATE_PTHREAD_RESULT(result);

} else {