Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 8362009: Add plugin type (NPAPI, PPAPI, etc.) to chrome://plugins. (Closed)

Created:
9 years, 2 months ago by viettrungluu
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews), darin-cc_chromium.org
Visibility:
Public.

Description

Add plugin type (NPAPI, PPAPI, etc.) to chrome://plugins. TEST=Go to about:plugins, show Details, verify that the "Type:" field is displayed correctly (e.g., "PPAPI (in-process)" for the Remoting Viewer, "NPAPI" for most third-party plugins). BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106610

Patch Set 1 #

Patch Set 2 : removed WebPluginInfo::PluginType change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/plugins.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 4 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
9 years, 2 months ago (2011-10-20 20:45:25 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
9 years, 2 months ago (2011-10-20 20:52:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8362009/3001
9 years, 2 months ago (2011-10-20 21:24:27 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-20 22:43:57 UTC) #4
Change committed as 106610

Powered by Google App Engine
This is Rietveld 408576698