Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: src/stub-cache.h

Issue 8361028: Handlify StubCompiler::CompileCallInitialize. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/mips/ic-mips.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/stub-cache.h
diff --git a/src/stub-cache.h b/src/stub-cache.h
index c1fffc6a7bddd6f012c3034f46cd4f6b85c03339..a12e8a93ae30850406dd88b35a79c8fe8c6aaeb6 100644
--- a/src/stub-cache.h
+++ b/src/stub-cache.h
@@ -378,35 +378,32 @@ DECLARE_RUNTIME_FUNCTION(MaybeObject*, CallInterceptorProperty);
DECLARE_RUNTIME_FUNCTION(MaybeObject*, KeyedLoadPropertyWithInterceptor);
-// The stub compiler compiles stubs for the stub cache.
+// The stub compilers compile stubs for the stub cache.
class StubCompiler BASE_EMBEDDED {
public:
explicit StubCompiler(Isolate* isolate)
: isolate_(isolate), masm_(isolate, NULL, 256), failure_(NULL) { }
+ // Functions to compile either CallIC or KeyedCallIC. The specific kind
+ // is extracted from the code flags.
Handle<Code> CompileCallInitialize(Code::Flags flags);
- MUST_USE_RESULT MaybeObject* TryCompileCallInitialize(Code::Flags flags);
-
Handle<Code> CompileCallPreMonomorphic(Code::Flags flags);
- MUST_USE_RESULT MaybeObject* TryCompileCallPreMonomorphic(Code::Flags flags);
-
Handle<Code> CompileCallNormal(Code::Flags flags);
- MUST_USE_RESULT MaybeObject* TryCompileCallNormal(Code::Flags flags);
-
Handle<Code> CompileCallMegamorphic(Code::Flags flags);
- MUST_USE_RESULT MaybeObject* TryCompileCallMegamorphic(Code::Flags flags);
-
Handle<Code> CompileCallArguments(Code::Flags flags);
- MUST_USE_RESULT MaybeObject* TryCompileCallArguments(Code::Flags flags);
-
Handle<Code> CompileCallMiss(Code::Flags flags);
+
+ MUST_USE_RESULT MaybeObject* TryCompileCallPreMonomorphic(Code::Flags flags);
+ MUST_USE_RESULT MaybeObject* TryCompileCallNormal(Code::Flags flags);
+ MUST_USE_RESULT MaybeObject* TryCompileCallMegamorphic(Code::Flags flags);
+ MUST_USE_RESULT MaybeObject* TryCompileCallArguments(Code::Flags flags);
MUST_USE_RESULT MaybeObject* TryCompileCallMiss(Code::Flags flags);
#ifdef ENABLE_DEBUGGER_SUPPORT
Handle<Code> CompileCallDebugBreak(Code::Flags flags);
- MUST_USE_RESULT MaybeObject* TryCompileCallDebugBreak(Code::Flags flags);
-
Handle<Code> CompileCallDebugPrepareStepIn(Code::Flags flags);
+
+ MUST_USE_RESULT MaybeObject* TryCompileCallDebugBreak(Code::Flags flags);
MUST_USE_RESULT MaybeObject* TryCompileCallDebugPrepareStepIn(
Code::Flags flags);
#endif
@@ -502,8 +499,12 @@ class StubCompiler BASE_EMBEDDED {
Label* miss);
protected:
- MaybeObject* GetCodeWithFlags(Code::Flags flags, const char* name);
- MaybeObject* GetCodeWithFlags(Code::Flags flags, String* name);
+ Handle<Code> GetCodeWithFlags(Code::Flags flags, const char* name);
+
+ MUST_USE_RESULT MaybeObject* TryGetCodeWithFlags(Code::Flags flags,
+ const char* name);
+ MUST_USE_RESULT MaybeObject* TryGetCodeWithFlags(Code::Flags flags,
+ String* name);
MacroAssembler* masm() { return &masm_; }
void set_failure(Failure* failure) { failure_ = failure; }
« no previous file with comments | « src/mips/ic-mips.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698