Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8361027: Re-commit 106660 with the crashing test disabled. (Closed)

Created:
9 years, 2 months ago by not at google - send to devlin
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-commit 106660 with the crashing test disabled. Reverted in 106671. Add onChanged events to the extension settings API, both from sync and between split mode background pages. BUG=97545 TEST=ExtensionSettingsStorageUnittest, ExtensionSettingsSyncUnittest, ExtensionSettingsApitest Review URL: http://codereview.chromium.org/8177022 TBR=rsleevi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106848

Patch Set 1 #

Patch Set 2 : add crbug #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1663 lines, -471 lines) Patch
M chrome/browser/extensions/extension_event_names.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_event_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A chrome/browser/extensions/extension_setting_changes.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_setting_changes.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_settings_api.h View 5 chunks +18 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_settings_api.cc View 3 chunks +44 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_settings_apitest.cc View 1 7 chunks +133 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_settings_backend.h View 4 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_settings_backend.cc View 4 chunks +21 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_settings_frontend.h View 1 chunk +50 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_settings_frontend.cc View 2 chunks +152 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_settings_frontend_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_settings_leveldb_storage.cc View 9 chunks +32 lines, -14 lines 0 comments Download
A chrome/browser/extensions/extension_settings_observer.h View 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_settings_observer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_settings_storage.h View 2 chunks +24 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_settings_storage.cc View 2 chunks +40 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_settings_storage_cache.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_settings_storage_quota_enforcer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_settings_storage_unittest.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_settings_storage_unittest.cc View 7 chunks +296 lines, -238 lines 0 comments Download
M chrome/browser/extensions/extension_settings_sync_unittest.cc View 5 chunks +25 lines, -19 lines 0 comments Download
M chrome/browser/extensions/in_memory_extension_settings_storage.cc View 5 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/extensions/syncable_extension_settings_storage.h View 4 chunks +27 lines, -2 lines 0 comments Download
M chrome/browser/extensions/syncable_extension_settings_storage.cc View 5 chunks +137 lines, -24 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 2 chunks +33 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/experimental.settings.html View 5 chunks +365 lines, -21 lines 0 comments Download
M chrome/test/data/extensions/api_test/settings/split_incognito/background.html View 1 chunk +57 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
9 years, 2 months ago (2011-10-22 01:54:09 UTC) #1
commit-bot: I haz the power
No reviewers yet.
9 years, 2 months ago (2011-10-22 01:54:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/8361027/2001
9 years, 2 months ago (2011-10-22 01:55:18 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-22 03:32:09 UTC) #4 
Change committed as 106848

Powered by Google App Engine
This is Rietveld 408576698