Track all extension processes in ExtensionInfoMap

Track all extension processes in ExtensionInfoMap, not just
those with bindings. This also allows us to tighten down
access in ExtensionFunctionDispatcher a bit more.

This is needed to allow us to answer questions about process
capabilities on the IO thread. For example:

http://codereview.chromium.org/%20%208312005/

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106876

[Aaron Boodman, 2011-10-20 23:34:42]

+dcheng fyi

[Matt Perry, 2011-10-21 18:28:51]

lgtm

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_info_map.cc (right):

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_info_map.cc:103:
ExtensionProcessIDMap::value_type(extension_id, process_id));
i think you can also use std::make_pair, but it's up to you which you prefer

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_info_map.h (right):

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_info_map.h:67: int
IsExtensionInProcess(const std::string& extension_id,
return bool and update the comment

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_process_manager.cc:317:
ProcessIDMap::iterator iter = process_ids_.find(render_process_id);
This code might be cleaner if the helper was instead
GetProcessIDAndRemove(site_instance_id), since the helper already has the
iterators.

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_process_manager.cc:326:
site_instance->GetProcess()->browser_context());
Is GetProcess guaranteed to be non-NULL? The old code checks HasProcess first.

Also, if all you want is the ExtensionInfoMap, you can get it through the
browsing_instance_->browser_context() instead (since it the EIM is shared
between normal and incognito).

[Aaron Boodman, 2011-10-22 04:02:42]

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_info_map.cc (right):

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_info_map.cc:103:
ExtensionProcessIDMap::value_type(extension_id, process_id));
On 2011/10/21 18:28:51, Matt Perry wrote:
> i think you can also use std::make_pair, but it's up to you which you prefer

Oh, that is better. Thanks.

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_info_map.h (right):

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_info_map.h:67: int
IsExtensionInProcess(const std::string& extension_id,
On 2011/10/21 18:28:51, Matt Perry wrote:
> return bool and update the comment

Done.

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/8361021/diff/3002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_process_manager.cc:326:
site_instance->GetProcess()->browser_context());
On 2011/10/21 18:28:51, Matt Perry wrote:
> Is GetProcess guaranteed to be non-NULL? The old code checks HasProcess first.
> 
> Also, if all you want is the ExtensionInfoMap, you can get it through the
> browsing_instance_->browser_context() instead (since it the EIM is shared
> between normal and incognito).

Done.

[commit-bot: I haz the power, 2011-10-22 04:05:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/8361021/9002

[commit-bot: I haz the power, 2011-10-22 06:55:54]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 106848, job name
was 8361021-9002 (retry) (retry) (retry) (retry).

[commit-bot: I haz the power, 2011-10-22 07:12:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/8361021/9002

[commit-bot: I haz the power, 2011-10-22 09:36:16]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 106848, job name
was 8361021-9002 (retry) (retry) (retry) (retry).

[commit-bot: I haz the power, 2011-10-23 06:55:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/8361021/9002

[commit-bot: I haz the power, 2011-10-23 06:55:08]

Failed to send try job 8361021-9002: 2