chrome/default_plugin/plugin_impl_win.cc - Issue 8361011: Tweak PathProviderPosix's FILE_EXE and FILE_MODULE handling on FreeBSD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/default_plugin/plugin_impl_win.cc

Issue 8361011: Tweak PathProviderPosix's FILE_EXE and FILE_MODULE handling on FreeBSD. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: incorporated tony's comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/default_plugin/plugin_impl_win.cc

diff --git a/chrome/default_plugin/plugin_impl_win.cc b/chrome/default_plugin/plugin_impl_win.cc

index d61228b5435066ceac471f9b5881695493f8c8f4..cbf7661f7ede626a93735b209afcf4f6972345e7 100644

--- a/chrome/default_plugin/plugin_impl_win.cc

+++ b/chrome/default_plugin/plugin_impl_win.cc

@@ -72,7 +72,7 @@ bool PluginInstallerImpl::Initialize(HINSTANCE module_handle, NPP instance,

DCHECK(instance != NULL);

DCHECK(module_handle != NULL);

- if (mime_type == NULL || strlen(mime_type) == 0) {

+ if (mime_type == NULL || *mime_type == '\0') {

NOTREACHED() << __FUNCTION__ << " Invalid parameters passed in";

return false;

}