Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: webkit/glue/webkitplatformsupport_impl.cc

Issue 8361011: Tweak PathProviderPosix's FILE_EXE and FILE_MODULE handling on FreeBSD. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: backed off on main strlen change Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base_paths_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webkitplatformsupport_impl.cc
diff --git a/webkit/glue/webkitplatformsupport_impl.cc b/webkit/glue/webkitplatformsupport_impl.cc
index bfa6ec04f871c0d6ad6772dece793af15261d94c..0ab77d3a87c3e29dd7cbd8ca1e290020183404d3 100644
--- a/webkit/glue/webkitplatformsupport_impl.cc
+++ b/webkit/glue/webkitplatformsupport_impl.cc
@@ -424,7 +424,7 @@ WebData WebKitPlatformSupportImpl::loadResource(const char* name) {
// Some clients will call into this method with an empty |name| when they have
// optional resources. For example, the PopupMenuChromium code can have icons
// for some Autofill items but not for others.
- if (!strlen(name))
+ if (name == NULL || !strlen(name))
wtc 2011/10/25 00:07:56 I would exclude this change. It may be wrong to p
grt (UTC plus 2) 2011/10/25 13:21:50 Done.
wtc 2011/10/25 17:42:30 Just FYI: my quick experiments showed that strlen(
return WebData();
// Check the name prefix to see if it's an audio resource.
« no previous file with comments | « base/base_paths_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698