base/base_paths_linux.cc - Issue 8361011: Tweak PathProviderPosix's FILE_EXE and FILE_MODULE handling on FreeBSD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base_paths_linux.cc

Issue 8361011: Tweak PathProviderPosix's FILE_EXE and FILE_MODULE handling on FreeBSD. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base_paths_linux.cc

diff --git a/base/base_paths_linux.cc b/base/base_paths_linux.cc

index b082eb3b3d71e6811ed385541df2df7268d1bb0e..3ff7880d6eb1e74bf6638313329fc840287a7a0f 100644

--- a/base/base_paths_linux.cc

+++ b/base/base_paths_linux.cc

@@ -51,7 +51,7 @@ bool PathProviderPosix(int key, FilePath* result) {

char bin_dir[PATH_MAX + 1];

size_t length = sizeof(bin_dir);

int error = sysctl(name, 4, bin_dir, &length, NULL, 0);

- if (error < 0 || length == 0 || strlen(bin_dir) == 0) {

+ if (error < 0 || length == 0 || *bin_dir == '\0') {

NOTREACHED() << "Unable to resolve path.";

return false;

}