Tweak PathProviderPosix's FILE_EXE and FILE_MODULE handling on FreeBSD.

webkit/glue/webkitplatformsupport_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webkitplatformsupport_impl.h"
 
 #if defined(OS_LINUX)
 #include <malloc.h>
 #endif
 
@@ skipping 406 matching lines @@
   { "soloCC", IDR_AUTOFILL_CC_SOLO },
   { "visaCC", IDR_AUTOFILL_CC_VISA },
 };
 
 }  // namespace
 
 WebData WebKitPlatformSupportImpl::loadResource(const char* name) {
   // Some clients will call into this method with an empty |name| when they have
   // optional resources.  For example, the PopupMenuChromium code can have icons
   // for some Autofill items but not for others.
-  if (!strlen(name))

[wtc, 2011/10/21 19:18:19]

Some strlen implementations may "helpfully" allow strlen(NULL)
to return 0.  I hope we don't pass a null |name| to
WebKitPlatformSupportImpl::loadResource.

+  if (*name == '\0')
     return WebData();
 
   // Check the name prefix to see if it's an audio resource.
   if (StartsWithASCII(name, "IRC_Composite", true))
     return loadAudioSpatializationResource(name);
 
   for (size_t i = 0; i < arraysize(kDataResources); ++i) {
     if (!strcmp(name, kDataResources[i].name)) {
       base::StringPiece resource = GetDataResource(kDataResources[i].id);
       return WebData(resource.data(), resource.size());
@@ skipping 237 matching lines @@
 }
 
 // static
 void WebKitPlatformSupportImpl::DestroyCurrentThread(void* thread) {
   WebThreadImplForMessageLoop* impl =
       static_cast<WebThreadImplForMessageLoop*>(thread);
   delete impl;
 }
 
 }  // namespace webkit_glue