Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/default_plugin/plugin_impl_win.cc

Issue 8361011: Tweak PathProviderPosix's FILE_EXE and FILE_MODULE handling on FreeBSD. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/default_plugin/plugin_impl_win.h" 5 #include "chrome/default_plugin/plugin_impl_win.h"
6 6
7 #include <shellapi.h> 7 #include <shellapi.h>
8 8
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 DestroyWindow(tooltip_); 65 DestroyWindow(tooltip_);
66 } 66 }
67 67
68 bool PluginInstallerImpl::Initialize(HINSTANCE module_handle, NPP instance, 68 bool PluginInstallerImpl::Initialize(HINSTANCE module_handle, NPP instance,
69 NPMIMEType mime_type, int16 argc, 69 NPMIMEType mime_type, int16 argc,
70 char* argn[], char* argv[]) { 70 char* argn[], char* argv[]) {
71 DVLOG(1) << __FUNCTION__ << " MIME Type : " << mime_type; 71 DVLOG(1) << __FUNCTION__ << " MIME Type : " << mime_type;
72 DCHECK(instance != NULL); 72 DCHECK(instance != NULL);
73 DCHECK(module_handle != NULL); 73 DCHECK(module_handle != NULL);
74 74
75 if (mime_type == NULL || strlen(mime_type) == 0) { 75 if (mime_type == NULL || *mime_type == '0') {
tony 2011/10/20 20:24:54 Missing \
grt (UTC plus 2) 2011/10/20 20:52:31 My mission for today is to prove the value of code
76 NOTREACHED() << __FUNCTION__ << " Invalid parameters passed in"; 76 NOTREACHED() << __FUNCTION__ << " Invalid parameters passed in";
77 return false; 77 return false;
78 } 78 }
79 79
80 instance_ = instance; 80 instance_ = instance;
81 mime_type_ = mime_type; 81 mime_type_ = mime_type;
82 82
83 ChildThread::current()->Send( 83 ChildThread::current()->Send(
84 new ChromePluginProcessHostMsg_GetPluginFinderUrl(&plugin_finder_url_)); 84 new ChromePluginProcessHostMsg_GetPluginFinderUrl(&plugin_finder_url_));
85 if (plugin_finder_url_.empty()) 85 if (plugin_finder_url_.empty())
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
670 void PluginInstallerImpl::NotifyPluginStatus(int status) { 670 void PluginInstallerImpl::NotifyPluginStatus(int status) {
671 #if !defined(USE_AURA) 671 #if !defined(USE_AURA)
672 ChildThread::current()->Send( 672 ChildThread::current()->Send(
673 new ChromePluginProcessHostMsg_MissingPluginStatus( 673 new ChromePluginProcessHostMsg_MissingPluginStatus(
674 status, 674 status,
675 renderer_process_id(), 675 renderer_process_id(),
676 render_view_id(), 676 render_view_id(),
677 hwnd())); 677 hwnd()));
678 #endif 678 #endif
679 } 679 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698