Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8361006: Fix subprocess2.Popen() logging when given a string (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Fix subprocess2.Popen() logging when given a string R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M subprocess2.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-20 17:49:28 UTC) #1
Dirk Pranke
lgtm
9 years, 2 months ago (2011-10-21 02:36:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8361006/1
9 years, 2 months ago (2011-10-21 12:42:40 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-21 12:48:28 UTC) #4 
Change committed as 106706

Powered by Google App Engine
This is Rietveld 408576698