Issue 8361004: Add ScopedDeque (similar to the existing ScopedVector).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8361004: Add ScopedDeque (similar to the existing ScopedVector). (Closed)

Created:
9 years, 2 months ago by Ian Vollick

Modified:
9 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add ScopedDeque (similar to the existing ScopedVector). BUG= TEST=base_unittests

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+288 lines, -0 lines)			Patch
M	base/base.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/base.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	base/memory/scoped_deque.h	View	1 chunk	+107 lines, -0 lines	0 comments	Download
A	base/memory/scoped_deque_unittest.cc	View	1 chunk	+179 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

This seems like a lot of code. Would it be reasonable for your use case ...

9 years, 2 months ago (2011-10-20 18:15:35 UTC) #2

Ian Vollick

9 years, 2 months ago (2011-10-20 18:46:42 UTC) #3

Yes, thank you. I think that linked_ptr will do the trick. Will close this
issue.

On 2011/10/20 18:15:35, brettw wrote:
> This seems like a lot of code. Would it be reasonable for your use case to use
a
> linked_ptr? We added ScopedVector before we had linked_ptr, which is a more
> scalable way of doing ownership with STL (since you can use it with anything
and
> it handles the edge cases).

Expand Messages | Collapse Messages