Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 8360028: Update the Mac 10.5 Valgrind binaries to valgrind-variant r106 (Closed)

Created:
9 years, 2 months ago by Alexander Potapenko
Modified:
9 years, 2 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, oshima
Visibility:
Public.

Description

Update the Mac 10.5 Valgrind binaries to valgrind-variant r106 TBR=timurrrr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M binaries/mac/bin/no_op_client_for_valgrind View Binary file 0 comments Download
M binaries/mac/bin/valgrind View Binary file 0 comments Download
M binaries/mac/bin/valgrind-listener View Binary file 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin View 0 chunks +-1 lines, --1 lines 0 comments Download
M binaries/mac/lib/valgrind/memcheck-x86-darwin View Binary file 0 comments Download
binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin View 0 chunks +-1 lines, --1 lines 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so View Binary file 0 comments Download
binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
TBR
9 years, 2 months ago (2011-10-21 12:50:19 UTC) #1
Timur Iskhodzhanov
9 years, 2 months ago (2011-10-21 12:56:27 UTC) #2
LGTM

On Fri, Oct 21, 2011 at 4:50 PM,  <glider@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov,
>
> Message:
> TBR
>
> Description:
> Update the Mac 10.5 Valgrind binaries to valgrind-variant r106
>
> TBR=timurrrr
>
> Please review this at http://codereview.chromium.org/8360028/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
>
> Affected files:
>  M     README.chromium
>  M     binaries/mac/bin/no_op_client_for_valgrind
>  binaries/mac/bin/valgrind
>  M     binaries/mac/bin/valgrind-listener
>  binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so
>  M
> binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Info.plist
>  binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so
>  M
> binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Info.plist
>  M
>
binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so
>  M     binaries/mac/lib/valgrind/memcheck-amd64-darwin
>  M
> binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Info.plist
>
 binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin
>  M     binaries/mac/lib/valgrind/memcheck-x86-darwin
>  binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Info.plist
>
 binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin
>  M     binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so
>
 binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Info.plist
>  binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so
>
 binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Info.plist
>  M
>
binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so
>  binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so
>
 binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Info.plist
>  M     binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so
>  M
>
binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Info.plist
>  M
>
binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so
>
>
> Index: README.chromium
> ===================================================================
> --- README.chromium     (revision 106704)
> +++ README.chromium     (working copy)
> @@ -2,7 +2,8 @@
>  Version: unknown
>
>  Memcheck version on Linux (valgrind-variant): 106
> -Memcheck version on Mac (valgrind-variant): 106
> +Memcheck version on Mac 10.5 (valgrind-variant): 106
> +Memcheck version on Mac 10.6 (valgrind-variant): 106
>
>  TSan version on Linux: unknown
>  TSan version on Mac: unknown
> Index: binaries/mac/bin/no_op_client_for_valgrind
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/bin/valgrind
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/bin/valgrind-listener
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
> binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Info.plist
> ===================================================================
> ---
> binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Info.plist
>       (revision 106486)
> +++
> binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Info.plist
>       (working copy)
> @@ -19,7 +19,7 @@
>                <key>dSYM_UUID</key>
>                <dict>
>                        <key>x86_64</key>
> -
> <string>407E7CC7-57B7-C9E6-5C7D-116083E572F1</string>
> +
> <string>0D52273D-595F-D9C1-1D75-F69830BB8A51</string>
>                </dict>
>        </dict>
>  </plist>
> Index: binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
> binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Info.plist
> ===================================================================
> ---
> binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Info.plist
> (revision 106486)
> +++
> binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Info.plist
> (working copy)
> @@ -19,7 +19,7 @@
>                <key>dSYM_UUID</key>
>                <dict>
>                        <key>i386</key>
> -
> <string>A5100CBC-CABA-7AF5-81FA-9E8234B261D4</string>
> +
> <string>012DDFAB-0564-1A35-DD41-E881C5173147</string>
>                </dict>
>        </dict>
>  </plist>
> Index:
>
binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/lib/valgrind/memcheck-amd64-darwin
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
> binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Info.plist
> ===================================================================
> --- binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Info.plist
>    (revision 106486)
> +++ binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Info.plist
>    (working copy)
> @@ -19,7 +19,7 @@
>                <key>dSYM_UUID</key>
>                <dict>
>                        <key>x86_64</key>
> -
> <string>09C94721-B862-B414-52C8-173ACDD7DD0C</string>
> +
> <string>78C59158-4629-A5A1-B523-FD93F1025FA1</string>
>                </dict>
>        </dict>
>  </plist>
> Index:
>
binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/lib/valgrind/memcheck-x86-darwin
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
> binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Info.plist
> ===================================================================
> --- binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Info.plist
>    (revision 106486)
> +++ binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Info.plist
>    (working copy)
> @@ -19,7 +19,7 @@
>                <key>dSYM_UUID</key>
>                <dict>
>                        <key>i386</key>
> -
> <string>0AD54B11-A6A2-402C-822F-C6046E9621B8</string>
> +
> <string>2085F015-F7BA-4867-B884-1036E03BCFE2</string>
>                </dict>
>        </dict>
>  </plist>
> Index:
>
binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Info.plist
> ===================================================================
> ---
>
binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Info.plist
>   (revision 106486)
> +++
>
binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Info.plist
>   (working copy)
> @@ -19,7 +19,7 @@
>                <key>dSYM_UUID</key>
>                <dict>
>                        <key>x86_64</key>
> -
> <string>9264E568-800D-222E-AD4D-7573DAA727B4</string>
> +
> <string>917DB356-0F04-AD7B-1EFD-A1C6EB4DBABC</string>
>                </dict>
>        </dict>
>  </plist>
> Index: binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Info.plist
> ===================================================================
> ---
>
binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Info.plist
>     (revision 106486)
> +++
>
binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Info.plist
>     (working copy)
> @@ -19,7 +19,7 @@
>                <key>dSYM_UUID</key>
>                <dict>
>                        <key>i386</key>
> -
> <string>B957E019-4166-1D5B-EE49-A118AF794F40</string>
> +
> <string>A511402B-2D4A-2AFE-8785-D386682B8180</string>
>                </dict>
>        </dict>
>  </plist>
> Index:
>
binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Info.plist
> ===================================================================
> ---
>
binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Info.plist
>       (revision 106486)
> +++
>
binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Info.plist
>       (working copy)
> @@ -19,7 +19,7 @@
>                <key>dSYM_UUID</key>
>                <dict>
>                        <key>x86_64</key>
> -
> <string>515368DD-A172-4697-1F35-3D51750BC89E</string>
> +
> <string>027F68DB-69D7-A4C2-A713-9DEC19B9C4D1</string>
>                </dict>
>        </dict>
>  </plist>
> Index: binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Info.plist
> ===================================================================
> ---
>
binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Info.plist
> (revision 106486)
> +++
>
binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Info.plist
> (working copy)
> @@ -19,7 +19,7 @@
>                <key>dSYM_UUID</key>
>                <dict>
>                        <key>i386</key>
> -
> <string>5C9B6509-F863-D2E9-B5DE-3EC860801788</string>
> +
> <string>7917A15A-13D8-2592-65EA-52F1CA61092C</string>
>                </dict>
>        </dict>
>  </plist>
> Index:
>
binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
>
>
>

Powered by Google App Engine
This is Rietveld 408576698