runtime/vm/object.cc - Issue 8360027: Proper string comparison.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 8360027: Proper string comparison. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Test added. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 65db2a8cda48d2a0b81a0574bc71e88db7b8c26d..4577efa7fa689e66dfa3117abec2b4caf0828372 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -5344,7 +5344,7 @@ bool String::Equals(const char* str) const {

}

str += consumed;

}

- return true;

+ return str[0] == '\0';

cshapiro 2011/10/21 20:12:47 How about "*str == '\0'" instead to be consistent

Anton Muhin 2011/10/24 15:59:34 Done.

}

« no previous file with comments | « no previous file | runtime/vm/object_test.cc » ('j') | no next file with comments »