client/view/ConveyorView.dart - Issue 8360025: Move the individual property definitions from client/base/Css to CSSStyleDeclaration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/view/ConveyorView.dart

Issue 8360025: Move the individual property definitions from client/base/Css to CSSStyleDeclaration. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/view/ConveyorView.dart

diff --git a/client/view/ConveyorView.dart b/client/view/ConveyorView.dart

index 6b48ebdf436977627e0600ca99524ce5c78589a9..efcec80d40a528a8041af17c8d8f43e8dbd114d5 100644

--- a/client/view/ConveyorView.dart

+++ b/client/view/ConveyorView.dart

@@ -55,9 +55,9 @@ class ConveyorView extends CompositeView {

final style = container.style;

// TODO(jacobr): modify setTransitionDuration so the input is always

// specified in miliseconds rather than accepting a string.

- Css.setTransitionDuration(style, '${durationSeconds}s');

+ style.transitionDuration = '${durationSeconds}s';

final xTranslationPercent = -index * 100;

- Css.setTransform(style, 'translate3d(${xTranslationPercent}%, 0px, 0px)');

+ style.transform = 'translate3d(${xTranslationPercent}%, 0px, 0px)';

if (animationTimeoutId != null) {

window.clearTimeout(animationTimeoutId);

« no previous file with comments | « client/touch/Scroller.dart ('k') | client/view/PagedViews.dart » ('j') | no next file with comments »