Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 8360023: base: Reenable external templates in logging.h when using component build. (Closed)

Created:
9 years, 2 months ago by Elliot Glaysher
Modified:
9 years, 2 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, rvargas (doing something else)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

base: Reenable external templates in logging.h when using component build. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M base/logging.h View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
Darin: review Will: fyi
9 years, 2 months ago (2011-10-21 17:21:01 UTC) #1
darin (slow to review)
OK, LGTM What changed to make this work now?
9 years, 2 months ago (2011-10-24 06:53:49 UTC) #2
Elliot Glaysher
On 2011/10/24 06:53:49, darin wrote: > OK, LGTM > > What changed to make this ...
9 years, 2 months ago (2011-10-24 17:41:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8360023/1
9 years, 2 months ago (2011-10-24 17:41:40 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-10-24 20:20:35 UTC) #5
Change committed as 106966

Powered by Google App Engine
This is Rietveld 408576698