Move code starting the editor into a common function.

Move code starting the editor into a common function.

Windows users wouldn't get the same behavior on git cl vs gcl.
Improve automatic CRLF<->LF conversion, some gcl users would be \n repeated in
their description depending on the editor used.

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107106

[M-A Ruel, 2011-10-20 18:24:34]

http://codereview.chromium.org/8360007/diff/1/gcl.py
File gcl.py (left):

http://codereview.chromium.org/8360007/diff/1/gcl.py#oldcode1152
gcl.py:1152: if sys.platform == 'win32':
Not needed, FileRead() already does the EOL conversion.

[Dirk Pranke, 2011-10-21 02:45:39]

lgtm

[commit-bot: I haz the power, 2011-10-21 12:48:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8360007/1

[commit-bot: I haz the power, 2011-10-21 12:48:58]

Can't apply patch for file depot_tools/tests/gclient_utils_test.py.
While running patch -p1 --forward --force;
patching file depot_tools/tests/gclient_utils_test.py
Hunk #1 FAILED at 31.
1 out of 1 hunk FAILED -- saving rejects to file
depot_tools/tests/gclient_utils_test.py.rej

[commit-bot: I haz the power, 2011-10-25 13:26:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8360007/6001

[commit-bot: I haz the power, 2011-10-25 13:32:43]

Change committed as 107106