Issue 8360004: Avoid incremental marking write-barrier when constructing descriptor arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8360004: Avoid incremental marking write-barrier when constructing descriptor arrays. (Closed)

Created:
9 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Avoid incremental marking write-barrier when constructing descriptor arrays. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=9735

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -98 lines)			Patch
M	src/bootstrapper.cc	View	14 chunks	+34 lines, -26 lines	0 comments	Download
M	src/factory.cc	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/incremental-marking.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/incremental-marking.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/objects.h	View	10 chunks	+34 lines, -12 lines	1 comment	Download
M	src/objects.cc	View	13 chunks	+42 lines, -30 lines	0 comments	Download
M	src/objects-inl.h	View	5 chunks	+49 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 2 months ago (2011-10-21 10:17:43 UTC) #2

LGTM

http://codereview.chromium.org/8360004/diff/1/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/8360004/diff/1/src/objects.h#newcode2841
src/objects.h:2841: void SetNextEnumerationIndex(int index) {
You could just write this->set(kBlabla, Smi::FromInt(index))

Also several other places where the value is statically typed to be a Smi.

Expand Messages | Collapse Messages