Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8360003: [cros] OOBE: add histograms for Profile image fetching. (Closed)

Created:
9 years, 2 months ago by Ivan Korotkov
Modified:
9 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[cros] OOBE: add histograms for Profile image fetching. *) Histograms for Profile image fetching and image screen display times. *) Moved Picasa token to the beginning of the token list to be fetched. BUG=chromium-os:21815 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106905

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes. #

Patch Set 3 : Renamed HandleScreenShown. #

Total comments: 4

Patch Set 4 : Compare both time from C++. #

Patch Set 5 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -22 lines) Patch
M chrome/browser/chromeos/login/profile_image_downloader.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/chromeos/login/profile_image_downloader.cc View 1 2 3 2 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_screen.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_screen.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/net/gaia/token_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 2 3 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ivan Korotkov
9 years, 2 months ago (2011-10-20 15:53:53 UTC) #1
whywhat
lgtm http://codereview.chromium.org/8360003/diff/1/chrome/browser/chromeos/login/user_image_screen.cc File chrome/browser/chromeos/login/user_image_screen.cc (right): http://codereview.chromium.org/8360003/diff/1/chrome/browser/chromeos/login/user_image_screen.cc#newcode61 chrome/browser/chromeos/login/user_image_screen.cc:61: profile_image_load_start_time_ = base::Time::Now(); Isn't there a race (in ...
9 years, 2 months ago (2011-10-20 16:14:49 UTC) #2
Ivan Korotkov
http://codereview.chromium.org/8360003/diff/1/chrome/browser/chromeos/login/user_image_screen.cc File chrome/browser/chromeos/login/user_image_screen.cc (right): http://codereview.chromium.org/8360003/diff/1/chrome/browser/chromeos/login/user_image_screen.cc#newcode61 chrome/browser/chromeos/login/user_image_screen.cc:61: profile_image_load_start_time_ = base::Time::Now(); Hm, right. http://codereview.chromium.org/8360003/diff/1/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc (right): ...
9 years, 2 months ago (2011-10-20 17:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/8360003/5001
9 years, 2 months ago (2011-10-20 19:24:00 UTC) #4
commit-bot: I haz the power
Presubmit check for 8360003-5001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 2 months ago (2011-10-20 19:24:04 UTC) #5
Ivan Korotkov
Zel, would you take a look at token_service.cc? I need your OWNERS approval. The Picasa ...
9 years, 2 months ago (2011-10-20 19:37:35 UTC) #6
zel
http://codereview.chromium.org/8360003/diff/5001/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right): http://codereview.chromium.org/8360003/diff/5001/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js#newcode214 chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:214: chrome.send('onUserImageScreenShown', [(new Date()).getTime()/1000]); you should not use time from ...
9 years, 2 months ago (2011-10-20 21:57:44 UTC) #7
Ivan Korotkov
http://codereview.chromium.org/8360003/diff/5001/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right): http://codereview.chromium.org/8360003/diff/5001/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js#newcode214 chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:214: chrome.send('onUserImageScreenShown', [(new Date()).getTime()/1000]); Why? I'm interested in the delay ...
9 years, 2 months ago (2011-10-21 07:52:00 UTC) #8
Ivan Korotkov
9 years, 2 months ago (2011-10-21 12:29:52 UTC) #9 
http://codereview.chromium.org/8360003/diff/5001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right):

http://codereview.chromium.org/8360003/diff/5001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:214:
chrome.send('onUserImageScreenShown', [(new Date()).getTime()/1000]);
Hm, ok, as discussed offline it's better to use a consistent clock source, so
moving this to C++ side.

Powered by Google App Engine
This is Rietveld 408576698