chrome/browser/ui/views/download/download_shelf_view.cc - Issue 8359029: ui/gfx: Convert Canvas::DrawFocusRect() to use gfx::Rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_shelf_view.cc

Issue 8359029: ui/gfx: Convert Canvas::DrawFocusRect() to use gfx::Rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address Peter's review Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/download/download_shelf_view.cc

diff --git a/chrome/browser/ui/views/download/download_shelf_view.cc b/chrome/browser/ui/views/download/download_shelf_view.cc

index 148776b48b2e23d502eed9e282b5c8fcaab19560..8044192ffccb438846d0f60478f07758b4c3f092 100644

--- a/chrome/browser/ui/views/download/download_shelf_view.cc

+++ b/chrome/browser/ui/views/download/download_shelf_view.cc

@@ -163,7 +163,8 @@ void DownloadShelfView::OnPaint(gfx::Canvas* canvas) {

for (size_t i = 0; i < download_views_.size(); ++i) {

if (download_views_[i]->HasFocus()) {

gfx::Rect r = GetFocusRectBounds(download_views_[i]);

- canvas->DrawFocusRect(r.x(), r.y(), r.width(), r.height() - 1);

+ r.Inset(0, 0, 0, 1);

+ canvas->DrawFocusRect(r);

break;

}