Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5092)

Unified Diff: chrome/browser/resources/tracing/timeline_view.js

Issue 8359025: Tons of timeline tweaks (Closed)
Patch Set: nits Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/tracing/timeline_view.js
diff --git a/chrome/browser/resources/tracing/timeline_view.js b/chrome/browser/resources/tracing/timeline_view.js
index 107ba4863094b83c2a498321af9ad80ee40c0ec7..861f79bdf8878824fa7f34c0d358624810e80673 100644
--- a/chrome/browser/resources/tracing/timeline_view.js
+++ b/chrome/browser/resources/tracing/timeline_view.js
@@ -64,7 +64,6 @@ cr.define('tracing', function() {
},
set traceEvents(traceEvents) {
- console.log('TimelineView.refresh');
this.timelineModel_ = new tracing.TimelineModel(traceEvents);
// remove old timeline
@@ -72,10 +71,11 @@ cr.define('tracing', function() {
// create new timeline if needed
if (traceEvents.length) {
+ if (this.timeline_)
+ this.timeline_.detach();
this.timeline_ = new tracing.Timeline();
this.timeline_.model = this.timelineModel_;
this.timelineContainer_.appendChild(this.timeline_);
- this.timeline_.onResize();
this.timeline_.addEventListener('selectionChange',
this.onSelectionChangedBoundToThis_);
this.onSelectionChanged_();
@@ -85,7 +85,6 @@ cr.define('tracing', function() {
},
onSelectionChanged_: function(e) {
- console.log('selection changed');
var timeline = this.timeline_;
var selection = timeline.selection;
if (!selection.length) {

Powered by Google App Engine
This is Rietveld 408576698