Tons of timeline tweaks

chrome/browser/resources/tracing/timeline_model.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview TimelineModel is a parsed representation of the
  * TraceEvents obtained from base/trace_event in which the begin-end
  * tokens are converted into a hierarchy of processes, threads,
  * subrows, and slices.
@@ skipping 265 matching lines @@
             sliceID += ';' + event.args[x];
           var slice = state.openNonNestedSlices[sliceID];
           if (!slice)
             return;
           slice.slice.duration = event.ts - slice.slice.start;
           if (event.uts)
             slice.durationInUserTime = event.uts - slice.slice.startInUserTime;
 
           // Store the slice in a non-nested subrow.
           var thread = self.getOrCreateProcess(event.pid).
-                            getOrCreateThread(event.tid);
+                           getOrCreateThread(event.tid);

[James Hawkins, 2011/11/11 23:37:40]

nit: Indentation for wrapped lines is 4 spaces from start of previous line.

In fact, if you wrap the line after '=', this would be much cleaner. Here and
line 300.

[nduca, 2011/11/12 01:28:27]

Done.

           thread.addNonNestedSlice(slice.slice);
           delete state.openNonNestedSlices[name];
         } else {
           if (state.openSlices.length == 0) {
             // Ignore E events that are unmatched.
             return;
           }
           var slice = state.openSlices.pop().slice;
           slice.duration = event.ts - slice.start;
           if (event.uts)
             slice.durationInUserTime = event.uts - slice.startInUserTime;
 
           // Store the slice on the correct subrow.
           var thread = self.getOrCreateProcess(event.pid)
-                           .getOrCreateThread(event.tid);
+              .getOrCreateThread(event.tid);
           var subRowIndex = state.openSlices.length;
           thread.getSubrow(subRowIndex).push(slice);
 
           // Add the slice to the subSlices array of its parent.
           if (state.openSlices.length) {
             var parentSlice = state.openSlices[state.openSlices.length - 1];
             parentSlice.slice.subSlices.push(slice);
           }
         }
       }
@@ skipping 19 matching lines @@
         } else if (event.ph == 'M') {
           if (event.name == 'thread_name') {
             var thread = this.getOrCreateProcess(event.pid)
                              .getOrCreateThread(event.tid);
             thread.name = event.args.name;
           } else {
             this.importErrors.push('Unrecognized metadata name: ' + event.name);
           }
         } else {
           this.importErrors.push('Unrecognized event phase: ' + event.ph +
-                                 '(' + event.name + ')');
+              '(' + event.name + ')');
         }
       }
       this.pruneEmptyThreads();
       this.updateBounds();
 
       // Add end events for any events that are still on the stack. These
       // are events that were still open when trace was ended, and can often
       // indicate deadlock behavior.
       for (var ptid in threadStateByPTID) {
         var state = threadStateByPTID[ptid];
@@ skipping 98 matching lines @@
   };
 
   return {
     getStringHash: getStringHash,
     TimelineSlice: TimelineSlice,
     TimelineThread: TimelineThread,
     TimelineProcess: TimelineProcess,
     TimelineModel: TimelineModel
   };
 });