Tons of timeline tweaks

chrome/browser/resources/tracing/timeline_view.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview TimelineView visualizes TRACE_EVENT events using the
  * tracing.Timeline component.
  */
 cr.define('tracing', function() {
@@ skipping 46 matching lines @@
       this.summaryEl_.className = 'summary';
 
       summaryContainer_.appendChild(this.summaryEl_);
       this.appendChild(this.timelineContainer_);
       this.appendChild(summaryContainer_);
 
       this.onSelectionChangedBoundToThis_ = this.onSelectionChanged_.bind(this);
     },
 
     set traceEvents(traceEvents) {
-      console.log('TimelineView.refresh');
       this.timelineModel_ = new tracing.TimelineModel(traceEvents);
 
       // remove old timeline
       this.timelineContainer_.textContent = '';
 
       // create new timeline if needed
       if (traceEvents.length) {
+        if (this.timeline_)
+          this.timeline_.detach();
         this.timeline_ = new tracing.Timeline();
         this.timeline_.model = this.timelineModel_;
         this.timelineContainer_.appendChild(this.timeline_);
-        this.timeline_.onResize();
         this.timeline_.addEventListener('selectionChange',
                                         this.onSelectionChangedBoundToThis_);
         this.onSelectionChanged_();
       } else {
         this.timeline_ = null;
       }
     },
 
     onSelectionChanged_: function(e) {
-      console.log('selection changed');
       var timeline = this.timeline_;
       var selection = timeline.selection;
       if (!selection.length) {
         var oldScrollTop = this.timelineContainer_.scrollTop;
         this.summaryEl_.textContent = timeline.keyHelp;
         this.timelineContainer_.scrollTop = oldScrollTop;
         return;
       }
 
       var text = '';
       if (selection.length == 1) {
         var c0Width = 14;
         var slice = selection[0].slice;
         text = 'Selected item:\n';
         text += leftAlign('Title', c0Width) + ': ' + slice.title + '\n';
         text += leftAlign('Start', c0Width) + ': ' +
             tsRound(slice.start) + ' ms\n';
         text += leftAlign('Duration', c0Width) + ': ' +
             tsRound(slice.duration) + ' ms\n';
-        text += leftAlign('Duration (U)', c0Width) + ': ' +
-            tsRound(slice.durationInUserTime) + ' ms\n';
+        if (slice.durationInUserTime)
+          text += leftAlign('Duration (U)', c0Width) + ': ' +
+              tsRound(slice.durationInUserTime) + ' ms\n';
 
         var n = 0;
         for (var argName in slice.args) {
           n += 1;
         }
         if (n > 0) {
           text += leftAlign('Args', c0Width) + ':\n';
           for (var argName in slice.args) {
             var argVal = slice.args[argName];
             text += leftAlign(' ' + argName, c0Width) + ': ' + argVal + '\n';
@@ skipping 55 matching lines @@
       var oldScrollTop = this.timelineContainer_.scrollTop;
       this.summaryEl_.textContent = text;
       this.timelineContainer_.scrollTop = oldScrollTop;
     }
   };
 
   return {
     TimelineView: TimelineView
   };
 });