Issue 8359024: Moved QTKit Valgrind suppression to third party.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8359024: Moved QTKit Valgrind suppression to third party. (Closed)

Created:
9 years, 2 months ago by mflodman_chromium_OOO

Modified:
9 years, 2 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, dmac

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Moved QTKit Valgrind suppression to third party. BUG=100772 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106903

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -25 lines)			Patch
	M	tools/valgrind/memcheck/suppressions_mac.txt	View		2 chunks	+26 lines, -25 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mflodman_chromium_OOO

Lei, I moved the QTKit leak up to third party, see http://crbug.com/100772 Can you review ...

9 years, 2 months ago (2011-10-21 09:38:09 UTC) #1

Lei Zhang

9 years, 2 months ago (2011-10-21 12:04:24 UTC) #2

lgtm

http://codereview.chromium.org/8359024/diff/1/tools/valgrind/memcheck/suppres...
File tools/valgrind/memcheck/suppressions_mac.txt (right):

http://codereview.chromium.org/8359024/diff/1/tools/valgrind/memcheck/suppres...
tools/valgrind/memcheck/suppressions_mac.txt:296: # QTKit leak. See
http://crbug.com/100772 and rdar://10319535.
nit: indentation

Expand Messages | Collapse Messages