Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: chrome/browser/history/history_types.h

Issue 8359019: Create Private Data for InMemoryURLIndex (in Preparation for SQLite Cache) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_types.h
===================================================================
--- chrome/browser/history/history_types.h (revision 107888)
+++ chrome/browser/history/history_types.h (working copy)
@@ -74,6 +74,13 @@
URLRow& operator=(const URLRow& other);
URLID id() const { return id_; }
+
+ // Sets the id of the row. The id should only be manually set when a row has
+ // been retrieved from the history database or other dataset based on criteria
+ // other than its id (i.e. by URL) and when the id has not yet been set in the
+ // row.
+ void set_id(URLID id) { id_ = id; }
+
const GURL& url() const { return url_; }
const string16& title() const {
@@ -140,8 +147,9 @@
// This excludes objects which autoinitialize such as strings.
void Initialize();
- // The row ID of this URL. Immutable except for the database which sets it
- // when it pulls them out.
+ // The row ID of this URL from the history database. This is immutable except
+ // when retrieving the row from the database or when determining if the URL
+ // referenced by the URLRow already exists in the database.
URLID id_;
// The URL of this row. Immutable except for the database which sets it
« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider_unittest.cc ('k') | chrome/browser/history/in_memory_url_index.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698