tests/gclient_scm_test.py - Issue 8359018: Fix a concurrency issue happening with deep dependencies when the intermediary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gclient_scm_test.py

Issue 8359018: Fix a concurrency issue happening with deep dependencies when the intermediary (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gclient_scm_test.py

diff --git a/tests/gclient_scm_test.py b/tests/gclient_scm_test.py

index c69ad2fca846bf97649be9b5e8cab08c593755d9..44d23aa30b8042f8497182208f96477ac7b93cf7 100755

--- a/tests/gclient_scm_test.py

+++ b/tests/gclient_scm_test.py

@@ -142,6 +142,10 @@ class SVNWrapperTestCase(BaseTestCase):

gclient_scm.os.path.exists(join(self.base_path, '.hg')).AndReturn(False)

# Checkout.

gclient_scm.os.path.exists(self.base_path).AndReturn(False)

+ parent = gclient_scm.os.path.dirname(self.base_path)

+ gclient_scm.os.path.exists(parent).AndReturn(False)

+ gclient_scm.os.makedirs(parent)

+ gclient_scm.os.path.exists(parent).AndReturn(True)

files_list = self.mox.CreateMockAnything()

gclient_scm.scm.SVN.RunAndGetFileList(

options.verbose,

@@ -167,6 +171,10 @@ class SVNWrapperTestCase(BaseTestCase):

gclient_scm.os.path.exists(join(self.base_path, '.git')).AndReturn(False)

gclient_scm.os.path.exists(join(self.base_path, '.hg')).AndReturn(False)

gclient_scm.os.path.exists(self.base_path).AndReturn(False)

+ parent = gclient_scm.os.path.dirname(self.base_path)

+ gclient_scm.os.path.exists(parent).AndReturn(False)

+ gclient_scm.os.makedirs(parent)

+ gclient_scm.os.path.exists(parent).AndReturn(True)

files_list = self.mox.CreateMockAnything()

gclient_scm.scm.SVN.Capture(['--version']).AndReturn('svn, version 1.6')

gclient_scm.scm.SVN.RunAndGetFileList(

@@ -255,6 +263,10 @@ class SVNWrapperTestCase(BaseTestCase):

gclient_scm.os.path.exists(join(self.base_path, '.hg')).AndReturn(False)

# Checkout.

gclient_scm.os.path.exists(self.base_path).AndReturn(False)

+ parent = gclient_scm.os.path.dirname(self.base_path)

+ gclient_scm.os.path.exists(parent).AndReturn(False)

+ gclient_scm.os.makedirs(parent)

+ gclient_scm.os.path.exists(parent).AndReturn(True)

files_list = self.mox.CreateMockAnything()

gclient_scm.scm.SVN.Capture(['--version']

).AndReturn('svn, version 1.5.1 (r32289)')

« no previous file with comments | « gclient_utils.py ('k') | tests/gclient_utils_test.py » ('j') | no next file with comments »