Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Side by Side Diff: chrome/browser/ui/webui/options/extension_settings_handler.cc

Issue 8359008: Improve extension settings accessibility. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/options/extension_settings_handler.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/base64.h" 8 #include "base/base64.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 localized_strings->SetString("extensionSettingsPackButton", 561 localized_strings->SetString("extensionSettingsPackButton",
562 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PACK_BUTTON)); 562 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PACK_BUTTON));
563 localized_strings->SetString("extensionSettingsUpdateButton", 563 localized_strings->SetString("extensionSettingsUpdateButton",
564 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UPDATE_BUTTON)); 564 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UPDATE_BUTTON));
565 localized_strings->SetString("extensionSettingsCrashMessage", 565 localized_strings->SetString("extensionSettingsCrashMessage",
566 l10n_util::GetStringUTF16(IDS_EXTENSIONS_CRASHED_EXTENSION)); 566 l10n_util::GetStringUTF16(IDS_EXTENSIONS_CRASHED_EXTENSION));
567 localized_strings->SetString("extensionSettingsInDevelopment", 567 localized_strings->SetString("extensionSettingsInDevelopment",
568 l10n_util::GetStringUTF16(IDS_EXTENSIONS_IN_DEVELOPMENT)); 568 l10n_util::GetStringUTF16(IDS_EXTENSIONS_IN_DEVELOPMENT));
569 localized_strings->SetString("extensionSettingsWarningsTitle", 569 localized_strings->SetString("extensionSettingsWarningsTitle",
570 l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_TITLE)); 570 l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_TITLE));
571
572 // TODO(dmazzoni) Uncomment these strings once this change is merged.
Finnur 2011/10/21 09:35:46 nit: Semicolon after close parenthesis.
dmazzoni 2011/10/21 16:29:38 Done - I think you mean colon?
Finnur 2011/10/21 16:46:21 Correct. I meant open braces. :) Just kidding. :)
573 localized_strings->SetString("extensionSettingsShowDetails",
574 ""); // l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_DETAILS));
575 localized_strings->SetString("extensionSettingsHideDetails",
576 ""); // l10n_util::GetStringUTF16(IDS_EXTENSIONS_HIDE_DETAILS));
571 } 577 }
572 578
573 void ExtensionSettingsHandler::Initialize() { 579 void ExtensionSettingsHandler::Initialize() {
574 } 580 }
575 581
576 WebUIMessageHandler* ExtensionSettingsHandler::Attach(WebUI* web_ui) { 582 WebUIMessageHandler* ExtensionSettingsHandler::Attach(WebUI* web_ui) {
577 // Call through to superclass. 583 // Call through to superclass.
578 WebUIMessageHandler* handler = OptionsPageUIHandler::Attach(web_ui); 584 WebUIMessageHandler* handler = OptionsPageUIHandler::Attach(web_ui);
579 585
580 extension_service_ = Profile::FromWebUI(web_ui_) 586 extension_service_ = Profile::FromWebUI(web_ui_)
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 continue; 806 continue;
801 } else if (!extension->web_extent().MatchesURL(url)) { 807 } else if (!extension->web_extent().MatchesURL(url)) {
802 continue; 808 continue;
803 } 809 }
804 810
805 result->push_back( 811 result->push_back(
806 ExtensionPage(url, process->id(), host->routing_id(), 812 ExtensionPage(url, process->id(), host->routing_id(),
807 process->browser_context()->IsOffTheRecord())); 813 process->browser_context()->IsOffTheRecord()));
808 } 814 }
809 } 815 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698