Notify Desktop::OnHostRezied only when the size has changed or resize is requsted.

Notify Desktop::OnHostRezied only when the size has changed or resize is requsted
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106927

[sadrul, 2011-10-20 19:09:31]

With this change, if DesktopHostLinux::SetSize is called more than once, it
would not trigger OnHostResized on subsequent calls? I don't believe we want
that?

I suppose the purpose of this change is to avoid calling OnHostResized when the
size doesn't actually change? In that case, perhaps Desktop could remember the
size the host last had, or DesktopHostLinux would hold a flag telling it that it
is expecting a Configure event, set to true in ::SetSize, and it would trigger
OnHostResized if 'expect_configure_event_ || bounds_.size() != size'

[oshima, 2011-10-20 19:50:20]

On 2011/10/20 19:09:31, sadrul wrote:
> With this change, if DesktopHostLinux::SetSize is called more than once, it
> would not trigger OnHostResized on subsequent calls? I don't believe we want
> that?
> I suppose the purpose of this change is to avoid calling OnHostResized when
the
> size doesn't actually change? In that case, perhaps Desktop could remember the
> size the host last had, or DesktopHostLinux would hold a flag telling it that
it
> is expecting a Configure event, set to true in ::SetSize, and it would trigger
> OnHostResized if 'expect_configure_event_ || bounds_.size() != size'

I see, but I prefer fixing in the way that we call OnHostResized only when it's
resized
because that's what it is. It's strange that you get OnHostResized, but still
have to check if
it's really resized. I understand it may not be practical though (due to X
async-ness).
Let's dicsuss on irc.

[oshima, 2011-10-21 23:45:17]

Uploaded new patch. PTAL

[sadrul, 2011-10-22 17:16:36]

lgtm

[commit-bot: I haz the power, 2011-10-22 23:26:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8359005/3001

[commit-bot: I haz the power, 2011-10-22 23:26:43]

Failed to send try job 8359005-3001: 2

[commit-bot: I haz the power, 2011-10-23 00:04:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8359005/3001

[commit-bot: I haz the power, 2011-10-23 00:04:17]

Failed to send try job 8359005-3001: 2

[commit-bot: I haz the power, 2011-10-23 03:54:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8359005/3001

[commit-bot: I haz the power, 2011-10-23 03:54:44]

Failed to send try job 8359005-3001: 2

[commit-bot: I haz the power, 2011-10-23 09:24:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8359005/3001

[commit-bot: I haz the power, 2011-10-23 09:24:02]

Failed to send try job 8359005-3001: 2

[commit-bot: I haz the power, 2011-10-24 07:20:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8359005/3001

[commit-bot: I haz the power, 2011-10-24 08:23:20]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 106896, job name
was 8359005-3001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).