Restricting set of URL requests that get intercepted to gview to GET methods with scheme http

chrome/browser/chromeos/gview_request_interceptor_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "chrome/browser/chrome_plugin_service_filter.h"
 #include "chrome/browser/chromeos/gview_request_interceptor.h"
@@ skipping 11 matching lines @@
 #include "net/url_request/url_request_job_factory.h"
 #include "net/url_request/url_request_test_job.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/plugins/npapi/plugin_list.h"
 
 namespace chromeos {
 
 namespace {
 
+const char kPdfUrl[] = "http://foo.com/file.pdf";
+const char kPptUrl[] = "http://foo.com/file.ppt";
+const char kHtmlUrl[] = "http://foo.com/index.html";
+const char kPdfBlob[] = "blob:blobinternal:///d17c4eef-28e7-42bd-bafa-78d5cb8";
+
+const char kPdfUrlIntercepted[] =
+    "http://docs.google.com/gview?url=http%3A//foo.com/file.pdf";
+const char kPptUrlIntercepted[] =
+    "http://docs.google.com/gview?url=http%3A//foo.com/file.ppt";
+
 class GViewURLRequestTestJob : public net::URLRequestTestJob {
  public:
   explicit GViewURLRequestTestJob(net::URLRequest* request)
       : net::URLRequestTestJob(request, true) {
   }
 
   virtual bool GetMimeType(std::string* mime_type) const {
     // During the course of a single test, two URLRequestJobs are
     // created -- the first is for the viewable document URL, and the
     // second is for the rediected URL.  In order to test the
     // interceptor, the mime type of the first request must be one of
     // the supported viewable mime types.  So when the net::URLRequestJob
     // is a request for one of the test URLs that point to viewable
     // content, return an appropraite mime type.  Otherwise, return
     // "text/html".
-    if (request_->url() == GURL("http://foo.com/file.pdf")) {
+    const GURL& request_url = request_->url();
+    if (request_url == GURL(kPdfUrl) || request_url == GURL(kPdfBlob)) {
       *mime_type = "application/pdf";
-    } else if (request_->url() == GURL("http://foo.com/file.ppt")) {
+    } else if (request_url == GURL(kPptUrl)) {
       *mime_type = "application/vnd.ms-powerpoint";
     } else {
       *mime_type = "text/html";
     }
     return true;
   }
 
  private:
   ~GViewURLRequestTestJob() {}
 };
@@ skipping 126 matching lines @@
   TestingPrefService prefs_;
   scoped_refptr<PluginPrefs> plugin_prefs_;
   net::URLRequestJobFactory job_factory_;
   const net::URLRequestJobFactory* old_factory_;
   scoped_refptr<ResourceHandler> handler_;
   TestDelegate test_delegate_;
   FilePath pdf_path_;
 };
 
 TEST_F(GViewRequestInterceptorTest, DoNotInterceptHtml) {
-  net::URLRequest request(GURL("http://foo.com/index.html"), &test_delegate_);
+  net::URLRequest request(GURL(kHtmlUrl), &test_delegate_);
   SetupRequest(&request);
   request.Start();
   MessageLoop::current()->Run();
   EXPECT_EQ(0, test_delegate_.received_redirect_count());
-  EXPECT_EQ(GURL("http://foo.com/index.html"), request.url());
+  EXPECT_EQ(GURL(kHtmlUrl), request.url());
 }
 
 TEST_F(GViewRequestInterceptorTest, DoNotInterceptDownload) {
-  net::URLRequest request(GURL("http://foo.com/file.pdf"), &test_delegate_);
+  net::URLRequest request(GURL(kPdfUrl), &test_delegate_);
   SetupRequest(&request);
   request.set_load_flags(net::LOAD_IS_DOWNLOAD);
   request.Start();
   MessageLoop::current()->Run();
   EXPECT_EQ(0, test_delegate_.received_redirect_count());
-  EXPECT_EQ(GURL("http://foo.com/file.pdf"), request.url());
+  EXPECT_EQ(GURL(kPdfUrl), request.url());
 }
 
 TEST_F(GViewRequestInterceptorTest, DoNotInterceptPdfWhenEnabled) {
   SetPDFPluginLoadedState(true);
   plugin_prefs_->EnablePlugin(true, pdf_path_);
 
-  net::URLRequest request(GURL("http://foo.com/file.pdf"), &test_delegate_);
+  net::URLRequest request(GURL(kPdfUrl), &test_delegate_);
   SetupRequest(&request);
   request.Start();
   MessageLoop::current()->Run();
   EXPECT_EQ(0, test_delegate_.received_redirect_count());
-  EXPECT_EQ(GURL("http://foo.com/file.pdf"), request.url());
+  EXPECT_EQ(GURL(kPdfUrl), request.url());
 }
 
 TEST_F(GViewRequestInterceptorTest, InterceptPdfWhenDisabled) {
   SetPDFPluginLoadedState(true);
   plugin_prefs_->EnablePlugin(false, pdf_path_);
 
-  net::URLRequest request(GURL("http://foo.com/file.pdf"), &test_delegate_);
+  net::URLRequest request(GURL(kPdfUrl), &test_delegate_);
   SetupRequest(&request);
   request.Start();
   MessageLoop::current()->Run();
   EXPECT_EQ(1, test_delegate_.received_redirect_count());
-  EXPECT_EQ(
-      GURL("http://docs.google.com/gview?url=http%3A//foo.com/file.pdf"),
-      request.url());
+  EXPECT_EQ(GURL(kPdfUrlIntercepted), request.url());
 }
 
 TEST_F(GViewRequestInterceptorTest, InterceptPdfWithNoPlugin) {
   SetPDFPluginLoadedState(false);
 
-  net::URLRequest request(GURL("http://foo.com/file.pdf"), &test_delegate_);
+  net::URLRequest request(GURL(kPdfUrl), &test_delegate_);
   SetupRequest(&request);
   request.Start();
   MessageLoop::current()->Run();
   EXPECT_EQ(1, test_delegate_.received_redirect_count());
-  EXPECT_EQ(GURL("http://docs.google.com/gview?url=http%3A//foo.com/file.pdf"),
-                 request.url());
+  EXPECT_EQ(GURL(kPdfUrlIntercepted), request.url());
 }
 
 TEST_F(GViewRequestInterceptorTest, InterceptPowerpoint) {
-  net::URLRequest request(GURL("http://foo.com/file.ppt"), &test_delegate_);
+  net::URLRequest request(GURL(kPptUrl), &test_delegate_);
   SetupRequest(&request);
   request.Start();
   MessageLoop::current()->Run();
   EXPECT_EQ(1, test_delegate_.received_redirect_count());
-  EXPECT_EQ(GURL("http://docs.google.com/gview?url=http%3A//foo.com/file.ppt"),
-                 request.url());
+  EXPECT_EQ(GURL(kPptUrlIntercepted), request.url());
+}
+
+TEST_F(GViewRequestInterceptorTest, DoNotInterceptPost) {
+  SetPDFPluginLoadedState(false);
+
+  net::URLRequest request(GURL(kPdfUrl), &test_delegate_);
+  SetupRequest(&request);
+  request.set_method("POST");
+  request.Start();
+  MessageLoop::current()->Run();
+  EXPECT_EQ(0, test_delegate_.received_redirect_count());
+  EXPECT_EQ(GURL(kPdfUrl), request.url());
+}
+
+TEST_F(GViewRequestInterceptorTest, DoNotInterceptBlob) {
+  SetPDFPluginLoadedState(false);
+
+  net::URLRequest request(GURL(kPdfBlob), &test_delegate_);
+  SetupRequest(&request);
+  request.Start();
+  MessageLoop::current()->Run();
+  EXPECT_EQ(0, test_delegate_.received_redirect_count());
+  EXPECT_EQ(GURL(kPdfBlob), request.url());
 }
 
 }  // namespace
 
 }  // namespace chromeos