Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/resources/print_preview/margins_ui.js

Issue 8357009: Print Preview Cleanup: Creating enum with all custom events used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebasing Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/margins_ui.js
diff --git a/chrome/browser/resources/print_preview/margins_ui.js b/chrome/browser/resources/print_preview/margins_ui.js
index 8f142c59b04e672021a59852e58d77ddaf4809d7..7c4ac18b932b7e898be8962f816e9d88558a56b9 100644
--- a/chrome/browser/resources/print_preview/margins_ui.js
+++ b/chrome/browser/resources/print_preview/margins_ui.js
@@ -58,14 +58,16 @@ cr.define('print_preview', function() {
__proto__: HTMLDivElement.prototype,
/**
- * Adds an observer for |MarginsMayHaveChanged| event.
+ * Adds an observer for |customEvents.MARGINS_MAY_HAVE_CHANGED| event.
* @param {function} func A callback function to be called when
- * |MarginsMayHaveChanged| event occurs.
+ * |customEvents.MARGINS_MAY_HAVE_CHANGED| event occurs.
*/
addObserver: function(func) {
var uiPairs = this.pairsAsList;
- for (var i = 0; i < uiPairs.length; i++)
- uiPairs[i].box_.addEventListener('MarginsMayHaveChanged', func);
+ for (var i = 0; i < uiPairs.length; i++) {
+ uiPairs[i].box_.addEventListener(
+ customEvents.MARGINS_MAY_HAVE_CHANGED, func);
+ }
},
/**
@@ -133,7 +135,7 @@ cr.define('print_preview', function() {
addEventListeners_: function() {
var uiPairs = this.pairsAsList;
for (var i = 0; i < uiPairs.length; i++) {
- uiPairs[i].addEventListener('MarginsLineMouseDown',
+ uiPairs[i].addEventListener(customEvents.MARGINS_LINE_MOUSE_DOWN,
this.onMarginLineMouseDown.bind(this));
}
// After snapping to min/max the MarginUIPair might not receive the
@@ -187,7 +189,7 @@ cr.define('print_preview', function() {
onMouseMove_: function(e) {
var point = MarginsUI.convert({ x: e.x, y: e.y });
- var dragEvent = new cr.Event('DragEvent');
+ var dragEvent = new cr.Event(customEvents.DRAG);
dragEvent.dragDelta =
this.lastClickedMarginsUIPair.getDragDisplacementFrom(point);
dragEvent.destinationPoint = point;

Powered by Google App Engine
This is Rietveld 408576698