Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5628)

Unified Diff: chrome/browser/resources/print_preview/print_header.js

Issue 8357009: Print Preview Cleanup: Creating enum with all custom events used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/print_header.js
diff --git a/chrome/browser/resources/print_preview/print_header.js b/chrome/browser/resources/print_preview/print_header.js
index c73c9ae7d12557d675ba9b69a11bd16a41f131bb..4e8fcaf485cc95fd3a98f2f9c1ed51b799ae5a50 100644
--- a/chrome/browser/resources/print_preview/print_header.js
+++ b/chrome/browser/resources/print_preview/print_header.js
@@ -44,18 +44,16 @@ cr.define('print_preview', function() {
closePrintPreviewTab();
}.bind(this);
this.printButton_.onclick = this.onPrintButtonClicked_.bind(this);
- document.addEventListener('updateSummary',
+ document.addEventListener(customEvents.UPDATE_SUMMARY,
this.updateSummary_.bind(this));
- document.addEventListener('updatePrintButton',
+ document.addEventListener(customEvents.UPDATE_PRINT_BUTTON,
this.updatePrintButton_.bind(this));
- document.addEventListener('disableCancelButton',
- this.disableCancelButton.bind(this));
- document.addEventListener('PDFGenerationError',
+ document.addEventListener(customEvents.PDF_GENERATION_ERROR,
this.onPDFGenerationError_.bind(this));
},
/**
- * Executes when an |PDFGenerationError| event is occurs.
+ * Executes when a |customEvents.PDF_GENERATION_ERROR| event occurs.
* @private
*/
onPDFGenerationError_: function() {

Powered by Google App Engine
This is Rietveld 408576698