Print Preview Cleanup: Creating enum with all custom events used.

chrome/browser/resources/print_preview/margin_settings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Creates a Margins object that holds four margin values. The units in which
    * the values are expressed can be any numeric value.
@@ skipping 268 matching lines @@
       this.forceDisplayingMarginLines_ = false;
       this.marginsUI.show();
     },
 
     /**
      * Adds listeners to all margin related controls.
      * @private
      */
     addEventListeners_: function() {
       this.marginList_.onchange = this.onMarginsChanged_.bind(this);
-      document.addEventListener('PDFLoaded', this.onPDFLoaded_.bind(this));
-      document.addEventListener('PDFGenerationError',
+      document.addEventListener(customEvents.PDF_LOADED,
+                                this.onPDFLoaded_.bind(this));
+      document.addEventListener(customEvents.PDF_GENERATION_ERROR,
                                 this.onPDFGenerationError_.bind(this));
     },
 
     /**
-     * Executes when an 'PDFGenerationError' event occurs.
+     * Executes when a |customEvents.PDF_GENERATION_ERROR| event occurs.
      * @private
      */
     onPDFGenerationError_: function() {
       if (this.isCustomMarginsSelected()) {
         this.removeCustomMarginEventListeners_();
         this.marginsUI.hide(true);
       }
     },
 
     /**
-     * Executes whenever a "DragEvent" occurs.
+     * Executes whenever a |customEvents.MARGIN_LINE_DRAG| occurs.
      * @param {cr.Event} e The event that triggered this listener.
      */
-    onDragEvent_: function(e) {
+    onMarginsLineDrag_: function(e) {
       var dragDeltaInPoints = this.convertDragDeltaToPoints_(e.dragDelta);
       this.marginsUI.lastClickedMarginsUIPair.updateWhileDragging(
           dragDeltaInPoints, e.destinationPoint);
     },
 
     /**
      * @param {number} dragDelta The difference in pixels between the original
      *     and current postion of the last clicked margin line.
      * @return {number} The difference in points.
      * @private
@@ skipping 97 matching lines @@
       return this.marginsUI_;
     },
 
     /**
      * Adds listeners when the custom margins option is selected.
      * @private
      */
     addCustomMarginEventListeners_: function() {
       $('mainview').onmouseover = this.onMainviewMouseOver_.bind(this);
       $('sidebar').onmouseover = this.onSidebarMouseOver_.bind(this);
-      this.eventTracker_.add(
-          this.marginsUI, 'DragEvent', this.onDragEvent_.bind(this), false);
-      this.eventTracker_.add(document, 'marginTextboxFocused',
+      this.eventTracker_.add(this.marginsUI,
+                             customEvents.MARGIN_LINE_DRAG,
+                             this.onMarginsLineDrag_.bind(this),
+                             false);
+      this.eventTracker_.add(document, customEvents.MARGIN_TEXTBOX_FOCUSED,
                              this.onMarginTextboxFocused_.bind(this), false);
     },
 
     /**
      * Removes the event listeners associated with the custom margins option.
      * @private
      */
     removeCustomMarginEventListeners_: function() {
       $('mainview').onmouseover = null;
       $('sidebar').onmouseover = null;
-      this.eventTracker_.remove(this.marginsUI, 'DragEvent');
-      this.eventTracker_.remove(document, 'marginTextboxFocused');
+      this.eventTracker_.remove(this.marginsUI, customEvents.MARGIN_LINE_DRAG);
+      this.eventTracker_.remove(document, customEvents.MARGIN_TEXTBOX_FOCUSED);
       this.marginsUI.hide(true);
     },
 
     /**
      * Updates |this.marginsUI| depending on the specified margins and the
      * position of the page within the plugin.
      * @private
      */
     drawCustomMarginsUI_: function() {
       // TODO(dpapad): find out why passing |!this.areMarginsSettingsValid()|
@@ skipping 148 matching lines @@
       if (this.isCustomMarginsSelected()) {
         this.marginList_.options[
             MarginSettings.DEFAULT_MARGINS_OPTION_INDEX].selected = true;
         this.removeCustomMarginEventListeners_();
         this.forceDisplayingMarginLines_ = true;
         this.lastSelectedOption_ = MarginSettings.MARGINS_VALUE_DEFAULT;
       }
     },
 
     /**
-     * Executes when a PDFLoaded event occurs.
+     * Executes when a |customEvents.PDF_LOADED| event occurs.
      * @private
      */
     onPDFLoaded_: function() {
       if (!previewModifiable)
         fadeOutElement(this.marginsOption_);
     }
   };
 
   return {
     MarginSettings: MarginSettings,
     PageLayout: PageLayout,
     setNumberFormatAndMeasurementSystem:
         MarginSettings.setNumberFormatAndMeasurementSystem,
   };
 });