Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6415)

Unified Diff: chrome/browser/ui/cocoa/browser/avatar_button_controller.mm

Issue 8356028: Add shortcut to show avatar menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser/avatar_button_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm b/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm
index 42192f6139c1618e8617628b54d5beda8c3c8a60..f92c1c734ffe0cafbc7a7b665575cd1e12f83919 100644
--- a/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm
+++ b/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm
@@ -148,9 +148,20 @@ const CGFloat kMenuYOffsetAdjust = 1.0;
- (IBAction)buttonClicked:(id)sender {
DCHECK_EQ(self.buttonView, sender);
+ [self showAvatarBubble];
+}
+
+- (void)showAvatarBubble {
if (menuController_)
return;
+ NSWindowController* wc =
+ [browser_->window()->GetNativeHandle() windowController];
+ if ([wc isKindOfClass:[BrowserWindowController class]]) {
+ [static_cast<BrowserWindowController*>(wc)
+ lockBarVisibilityForOwner:self withAnimation:NO delay:NO];
+ }
+
NSView* view = self.view;
NSPoint point = NSMakePoint(NSMidX([view bounds]),
NSMaxY([view bounds]) - kMenuYOffsetAdjust);
@@ -169,6 +180,12 @@ const CGFloat kMenuYOffsetAdjust = 1.0;
}
- (void)bubbleWillClose:(NSNotification*)notif {
+ NSWindowController* wc =
+ [browser_->window()->GetNativeHandle() windowController];
+ if ([wc isKindOfClass:[BrowserWindowController class]]) {
+ [static_cast<BrowserWindowController*>(wc)
+ releaseBarVisibilityForOwner:self withAnimation:YES delay:NO];
+ }
menuController_ = nil;
}

Powered by Google App Engine
This is Rietveld 408576698