Issue 8356025: Move ContentMainDelegate to content/public/.

Issue 8356025: Move ContentMainDelegate to content/public/. (Closed)

Created:
9 years, 2 months ago by Jói

Modified:
9 years, 2 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move ContentMainDelegate to content/public/. Mostly a trivial move since the implementation for the class (now deleted) was do-nothing and the only subclass that didn't have a full implementation was ShellMainDelegate. BUG=98716 TEST=it builds + existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106549

Patch Set 1 #

Patch Set 2 : Add missing .gypi change #

Patch Set 3 : Update chrome/app/DEPS rules. #

Patch Set 4 : Merge to head. #

Patch Set 5 : Merge to head. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -158 lines)			Patch
M	chrome/app/DEPS	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/app/chrome_main_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/chrome_main_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/app/content_main.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
D	content/app/content_main_delegate.h	View		1 chunk	+0 lines, -74 lines	0 comments	Download
D	content/app/content_main_delegate.cc	View		1 chunk	+0 lines, -56 lines	0 comments	Download
M	content/content_app.gypi	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
A +	content/public/app/content_main_delegate.h	View		1 chunk	+15 lines, -16 lines	0 comments	Download
M	content/shell/shell_main_delegate.h	View		2 chunks	+16 lines, -4 lines	0 comments	Download
M	content/shell/shell_main_delegate.cc	View		2 chunks	+38 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm yay for pure abstract interfaces. i should have done that initially!

9 years, 2 months ago (2011-10-20 00:20:30 UTC) #2

Jói

FYI, I had to update chrome/app/DEPS. Instead of just "+content/app", It now has "+content/app", # ...

9 years, 2 months ago (2011-10-20 01:02:52 UTC) #3

jam

9 years, 2 months ago (2011-10-20 01:03:33 UTC) #4

sgtm

On Wed, Oct 19, 2011 at 6:02 PM, Jói Sigurðsson <joi@chromium.org> wrote:

> FYI, I had to update chrome/app/DEPS.
>
> Instead of just
>  "+content/app",
>
> It now has
>  "+content/app",  # TODO(joi): Remove once content API in place.
>  "+content/public/app",
>
> Cheers,
> Jói
>
>
> On Wed, Oct 19, 2011 at 5:20 PM,  <jam@chromium.org> wrote:
> > lgtm
> >
> > yay for pure abstract interfaces. i should have done that initially!
> >
> > http://codereview.chromium.org/8356025/
> >
>

Expand Messages | Collapse Messages