Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: src/v8natives.js

Issue 8356004: Make IsGenericDescriptor spec-conformant. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 366
367 // ES5 8.10.2. 367 // ES5 8.10.2.
368 function IsDataDescriptor(desc) { 368 function IsDataDescriptor(desc) {
369 if (IS_UNDEFINED(desc)) return false; 369 if (IS_UNDEFINED(desc)) return false;
370 return desc.hasValue() || desc.hasWritable(); 370 return desc.hasValue() || desc.hasWritable();
371 } 371 }
372 372
373 373
374 // ES5 8.10.3. 374 // ES5 8.10.3.
375 function IsGenericDescriptor(desc) { 375 function IsGenericDescriptor(desc) {
376 if (IS_UNDEFINED(desc)) return false;
376 return !(IsAccessorDescriptor(desc) || IsDataDescriptor(desc)); 377 return !(IsAccessorDescriptor(desc) || IsDataDescriptor(desc));
377 } 378 }
378 379
379 380
380 function IsInconsistentDescriptor(desc) { 381 function IsInconsistentDescriptor(desc) {
381 return IsAccessorDescriptor(desc) && IsDataDescriptor(desc); 382 return IsAccessorDescriptor(desc) && IsDataDescriptor(desc);
382 } 383 }
383 384
384 385
385 // ES5 8.10.4 386 // ES5 8.10.4
(...skipping 1220 matching lines...) Expand 10 before | Expand all | Expand 10 after
1606 1607
1607 function SetUpFunction() { 1608 function SetUpFunction() {
1608 %CheckIsBootstrapping(); 1609 %CheckIsBootstrapping();
1609 InstallFunctions($Function.prototype, DONT_ENUM, $Array( 1610 InstallFunctions($Function.prototype, DONT_ENUM, $Array(
1610 "bind", FunctionBind, 1611 "bind", FunctionBind,
1611 "toString", FunctionToString 1612 "toString", FunctionToString
1612 )); 1613 ));
1613 } 1614 }
1614 1615
1615 SetUpFunction(); 1616 SetUpFunction();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698